You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/08/01 11:23:49 UTC

[GitHub] spark pull request #20637: [SPARK-23466][SQL] Remove redundant null checks i...

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20637#discussion_r206841463
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala ---
    @@ -142,7 +143,7 @@ object GenerateUnsafeProjection extends CodeGenerator[Seq[Expression], UnsafePro
               case _ => s"$rowWriter.write($index, ${input.value});"
             }
     
    -        if (input.isNull == "false") {
    +        if (input.isNull == "false" || !nullable) {
    --- End diff --
    
    aren't those checks equivalent?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org