You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/17 09:34:35 UTC
[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #854: system/libuv: Bump to v1.42.0
no1wudi opened a new pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854
## Summary
Bump libuv to latest release with new porting (without libuv's builtin test currently), porting tree see:
https://github.com/no1wudi/incubator-nuttx-apps/tree/dev
Note: In this porting, we use standard POSIX system call instead of some nuttx's specific logic (they may have some benefits for code size or memory overhead)
## Impact
libuv
## Testing
Tested with adb on my custom board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r815274565
##########
File path: system/libuv/Kconfig
##########
@@ -17,20 +17,29 @@ config LIBUV_THREADPOOL_SIZE
int "libuv default thread pool size"
default 1
-config LIBUV_TEST
- tristate "Enable uv_run_tests"
- default n
+choice
+ prompt "libuv utils"
+
+config LIBUV_UTILS_NONE
Review comment:
merge to the first patch too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r815274395
##########
File path: system/libuv/Kconfig
##########
@@ -10,3 +10,11 @@ config LIBUV
select PIPES
---help---
Enable build for libuv asynchronous I/O Library
+
+if LIBUV
+
+config LIBUV_THREADPOOL_SIZE
Review comment:
merge to first patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r815274727
##########
File path: system/libuv/Makefile
##########
@@ -20,7 +20,7 @@
include $(APPDIR)/Make.defs
-LIBUV_PATCHS ?= $(sort $(wildcard $(LIBUV_DIR)/000*.patch))
+LIBUV_PATCHS ?= $(sort $(wildcard 000*.patch))
Review comment:
merge to the first patch too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r815274606
##########
File path: system/libuv/Kconfig
##########
@@ -6,7 +6,6 @@
config LIBUV
bool "libuv asynchronous I/O Library"
default n
- select CLOCK_MONOTONIC
Review comment:
merge to the first patch too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r710920736
##########
File path: system/libuv/0001-unix-check-wehter-SIGPROF-exists.patch
##########
@@ -0,0 +1,48 @@
+From 6aba4ab8a44c73e1a771cdffea3588e09f71ec22 Mon Sep 17 00:00:00 2001
+From: Huang Qi <hu...@xiaomi.com>
+Date: Mon, 12 Apr 2021 12:13:43 +0800
+Subject: [PATCH 1/6] unix: check wehter SIGPROF exists
+
+Signed-off-by: Huang Qi <hu...@xiaomi.com>
+Change-Id: I676ab6d271d1a224e3e570e27f15072a3bb23de4
+---
+ src/unix/loop.c | 2 ++
+ src/unix/posix-poll.c | 2 ++
+ 2 files changed, 4 insertions(+)
+
+diff --git a/src/unix/loop.c b/src/unix/loop.c
+index a88e71c3..dad463b3 100644
+--- a/src/unix/loop.c
++++ b/src/unix/loop.c
+@@ -220,8 +220,10 @@ int uv__loop_configure(uv_loop_t* loop, uv_loop_option option, va_list ap) {
+ if (option != UV_LOOP_BLOCK_SIGNAL)
+ return UV_ENOSYS;
+
++#ifdef SIGPROF
Review comment:
the change is general, let's upstream to libuv community.
##########
File path: system/libuv/0003-nuttx-initial-support.patch
##########
@@ -0,0 +1,171 @@
+From 9a33511642a63ccd0f862ed97597666438d44d23 Mon Sep 17 00:00:00 2001
+From: Huang Qi <hu...@xiaomi.com>
+Date: Fri, 19 Mar 2021 18:36:29 +0800
+Subject: [PATCH 3/6] nuttx: initial support
+
+Signed-off-by: Huang Qi <hu...@xiaomi.com>
+Change-Id: Ib680de8d8d5b4612e4f58cd37ff1398b4b73a7e1
+---
+ include/uv/unix.h | 2 ++
+ src/random.c | 2 +-
+ src/threadpool.c | 2 +-
+ src/unix/core.c | 2 +-
+ src/unix/nuttx.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
+ src/unix/signal.c | 3 ++-
+ src/unix/udp.c | 8 +++++---
+ 7 files changed, 57 insertions(+), 7 deletions(-)
+ create mode 100644 src/unix/nuttx.c
+
+diff --git a/include/uv/unix.h b/include/uv/unix.h
+index e3cf7bdd..bf8dc32c 100644
+--- a/include/uv/unix.h
++++ b/include/uv/unix.h
+@@ -71,6 +71,8 @@
+ # include "uv/posix.h"
+ #elif defined(__QNX__)
+ # include "uv/posix.h"
++#elif defined(__NuttX__)
Review comment:
let's upstream NuttX specific change to libuv community too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r815274424
##########
File path: system/libuv/Kconfig
##########
@@ -17,4 +17,20 @@ config LIBUV_THREADPOOL_SIZE
int "libuv default thread pool size"
default 1
+config LIBUV_TEST
Review comment:
merge to first patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#issuecomment-931817953
@no1wudi
```
====================================================================================
Configuration/Tool: stm32f4discovery/adb,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Building NuttX...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 127 100 127 0 0 651 0 --:--:-- --:--:-- --:--:-- 651
100 3490 0 3490 0 0 9457 0 --:--:-- --:--:-- --:--:-- 9457
100 1619k 0 1619k 0 0 3056k 0 --:--:-- --:--:-- --:--:-- 9.8M
From https://github.com/spiriou/microADB
* branch b7025c67b866925d1e64c016a844a6a3392557a4 -> FETCH_HEAD
In file included from /github/workspace/sources/apps/system/libuv/libuv/include/uv.h:66,
from libuv/src/unix/core.c:21:
Error: /github/workspace/sources/apps/system/libuv/libuv/include/uv/unix.h:382:18: error: field 'orig_termios' has incomplete type
382 | struct termios orig_termios; \
| ^~~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r815274475
##########
File path: system/libuv/Kconfig
##########
@@ -17,20 +17,29 @@ config LIBUV_THREADPOOL_SIZE
int "libuv default thread pool size"
default 1
-config LIBUV_TEST
- tristate "Enable uv_run_tests"
- default n
+choice
+ prompt "libuv utils"
Review comment:
add
default LIBUV_UTILS_NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r815274374
##########
File path: system/libuv/Kconfig
##########
@@ -6,8 +6,7 @@
config LIBUV
bool "libuv asynchronous I/O Library"
default n
- select EVENT_FD
- select EVENT_FD_POLL
select CLOCK_MONOTONIC
+ select PIPES
Review comment:
merge to previous patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#discussion_r815274751
##########
File path: system/libuv/Makefile
##########
@@ -86,6 +86,7 @@ CSRCS += pipe.c
CSRCS += fs.c
CSRCS += fs-poll.c
CSRCS += timer.c
+CSRCS += process.c
Review comment:
merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #854: system/libuv: Bump to v1.42.0
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #854:
URL: https://github.com/apache/incubator-nuttx-apps/pull/854#issuecomment-1052121764
This PR need the patch which remove -D__NUTTX__ from system/adb/Makefile to pass CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org