You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by gr...@apache.org on 2017/12/11 17:14:13 UTC
[2/2] mesos git commit: Edited some comments in the master for style
and grammar.
Edited some comments in the master for style and grammar.
Review: https://reviews.apache.org/r/64462/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d7c14eab
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/d7c14eab
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/d7c14eab
Branch: refs/heads/master
Commit: d7c14eab2f07911ff5d423b91291badd9f2e16d7
Parents: c1138c8
Author: Greg Mann <gr...@mesosphere.io>
Authored: Mon Dec 11 08:41:34 2017 -0800
Committer: Greg Mann <gr...@gmail.com>
Committed: Mon Dec 11 08:42:05 2017 -0800
----------------------------------------------------------------------
src/master/master.cpp | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/d7c14eab/src/master/master.cpp
----------------------------------------------------------------------
diff --git a/src/master/master.cpp b/src/master/master.cpp
index 0488efb..55e9195 100644
--- a/src/master/master.cpp
+++ b/src/master/master.cpp
@@ -7539,19 +7539,17 @@ void Master::updateSlave(const UpdateSlaveMessage& message)
resourceProviders) {
// Below we only add offer operations to our state from resource providers
// which are unknown, or possibly remove them for known resource providers.
- // This works since the master should always known more offer operations of
- // known resource provider than any resource provider itself.
+ // This works since the master should always know more offer operations of
+ // known resource providers than any resource provider itself.
//
- // NOTE: We do not mutate offer operations statuses here; this
- // would be the responsibility of a offer operation status
- // update handler.
+ // NOTE: We do not mutate offer operation statuses here; that is the
+ // responsibility of the `offerOperationStatusUpdate` handler.
//
- // There still exists a edge case where the master might remove a
- // terminal offer operation from its state when passing an
- // acknowledgement from a framework on to the agent with the agent
- // failing over before the acknowledgement can be processed. In
- // that case the agent would track an operation unknown to the
- // master.
+ // There still exists an edge case where the master might remove a terminal
+ // offer operation from its state when passing an acknowledgement from a
+ // framework on to the agent, with the agent failing over before the
+ // acknowledgement can be processed. In that case the agent would track an
+ // operation unknown to the master.
//
// TODO(bbannier): We might want to consider to also learn about
// new (terminal) operations when observing messages from status