You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/05/19 13:24:47 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #24135: chore(sqllab): remove deprecated PyArrow API
sebastianliebscher opened a new pull request, #24135:
URL: https://github.com/apache/superset/pull/24135
### SUMMARY
As @wjones127 suggested in https://github.com/apache/superset/issues/24030 this PR removes deprecated `.serialize `and `.deserialize`. This enables upgrade to latest pyarrow==12.0.0.
Thanks @wjones127!
Resolves https://github.com/apache/superset/issues/24030
### TESTING INSTRUCTIONS
`./scripts/tests/run.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #24135: chore(sqllab): remove deprecated PyArrow API
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #24135:
URL: https://github.com/apache/superset/pull/24135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher commented on pull request #24135: chore(sqllab): remove deprecated PyArrow API
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher commented on PR #24135:
URL: https://github.com/apache/superset/pull/24135#issuecomment-1554575816
ping @EugeneTorap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24135: chore(sqllab): remove deprecated PyArrow API
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24135:
URL: https://github.com/apache/superset/pull/24135#issuecomment-1554583929
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24135](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2fb73da) into [master](https://app.codecov.io/gh/apache/superset/commit/d583ca9ef57d1c49ae84cda8cc888ee01dcf5601?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d583ca9) will **decrease** coverage by `11.30%`.
> The diff coverage is `90.47%`.
> :exclamation: Current head 2fb73da differs from pull request most recent head 37144fc. Consider uploading reports for the commit 37144fc to get more accurate results
```diff
@@ Coverage Diff @@
## master #24135 +/- ##
===========================================
- Coverage 68.26% 56.96% -11.30%
===========================================
Files 1952 1952
Lines 75388 75403 +15
Branches 8202 8203 +1
===========================================
- Hits 51462 42955 -8507
- Misses 21819 30341 +8522
Partials 2107 2107
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.16% <81.81%> (+<0.01%)` | :arrow_up: |
| python | `59.41% <81.81%> (-23.40%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.17% <36.36%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/views/utils.py](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `48.66% <0.00%> (-32.25%)` | :arrow_down: |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `90.74% <100.00%> (+0.17%)` | :arrow_up: |
| [...dashboard/components/SliceHeaderControls/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXgudHN4) | `69.79% <100.00%> (+0.64%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `57.52% <100.00%> (+1.55%)` | :arrow_up: |
| [superset-frontend/src/logger/LogUtils.ts](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9Mb2dVdGlscy50cw==) | `97.22% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/sql\_lab.py](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `78.03% <100.00%> (-8.34%)` | :arrow_down: |
| [superset/sqllab/utils.py](https://app.codecov.io/gh/apache/superset/pull/24135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc3FsbGFiL3V0aWxzLnB5) | `86.66% <100.00%> (-13.34%)` | :arrow_down: |
... and [304 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24135/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org