You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Ali Sadik Kumlali (JIRA)" <ji...@apache.org> on 2006/12/06 15:20:22 UTC
[jira] Created: (AXIS2-1834) AddressingBasedDispatcher doesn't
dispatch according to the wsa:Action
AddressingBasedDispatcher doesn't dispatch according to the wsa:Action
----------------------------------------------------------------------
Key: AXIS2-1834
URL: http://issues.apache.org/jira/browse/AXIS2-1834
Project: Apache Axis 2.0 (Axis2)
Issue Type: Improvement
Components: kernel
Affects Versions: 1.1
Environment: Not important
Reporter: Ali Sadik Kumlali
AddressingBasedDispatcher only looks at <wsa:To> field. But in some situations, service should be resolved from <wsa:Action>. Consider following scenario:
- JMS transport is used
- Sender doesn't and cannot be able to set message header property called SOAPAction
In this case, service is not found as AddressingBasedDispatcher doesn't check <wsa:Action> field.
I've added <wsa:Action> check to AddressingBasedDispatcher::findService() and successfully used over my custom JMS transport listener(Please look at AXIS2-1585 for more details regarding MDB based JMS transport.)
Regards,
Ali Sadik Kumlali
P.S.: Patch was created under ...\branches\1_1\modules\kernel\src\org\apache\axis2\engine
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-1834) AddressingBasedDispatcher doesn't
dispatch according to the wsa:Action
Posted by "Ali Sadik Kumlali (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-1834?page=all ]
Ali Sadik Kumlali updated AXIS2-1834:
-------------------------------------
Attachment: patch.txt
Patch has been added.
> AddressingBasedDispatcher doesn't dispatch according to the wsa:Action
> ----------------------------------------------------------------------
>
> Key: AXIS2-1834
> URL: http://issues.apache.org/jira/browse/AXIS2-1834
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.1
> Environment: Not important
> Reporter: Ali Sadik Kumlali
> Attachments: patch.txt
>
>
> AddressingBasedDispatcher only looks at <wsa:To> field. But in some situations, service should be resolved from <wsa:Action>. Consider following scenario:
> - JMS transport is used
> - Sender doesn't and cannot be able to set message header property called SOAPAction
> In this case, service is not found as AddressingBasedDispatcher doesn't check <wsa:Action> field.
> I've added <wsa:Action> check to AddressingBasedDispatcher::findService() and successfully used over my custom JMS transport listener(Please look at AXIS2-1585 for more details regarding MDB based JMS transport.)
> Regards,
> Ali Sadik Kumlali
> P.S.: Patch was created under ...\branches\1_1\modules\kernel\src\org\apache\axis2\engine
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-1834) AddressingBasedDispatcher doesn't
dispatch according to the wsa:Action
Posted by "Ali Sadik Kumlali (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-1834?page=comments#action_12456101 ]
Ali Sadik Kumlali commented on AXIS2-1834:
------------------------------------------
Hi David,
You are totally right. But, for the JMS case, for example, wsa:To doesn't have service name[1]. Therefore, service dispatching based on wsa:To is impossible. That is why I created AXIS2-1665.
Regards,
Ali Sadik Kumlali
[1] <wsa:To>jms:/QUEUE_JNDI_NAME?transport.jms.ConnectionFactoryJNDIName=QueueConnectionFactory&java.naming.factory.initial=weblogic.jndi.WLInitialContextFactory&java.naming.provider.url=t3://localhost:7001&java.naming.security.principal=weblogic&java.naming.security.credentials=weblogic</wsa:To>
> AddressingBasedDispatcher doesn't dispatch according to the wsa:Action
> ----------------------------------------------------------------------
>
> Key: AXIS2-1834
> URL: http://issues.apache.org/jira/browse/AXIS2-1834
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.1
> Environment: Not important
> Reporter: Ali Sadik Kumlali
> Attachments: patch.txt
>
>
> AddressingBasedDispatcher only looks at <wsa:To> field. But in some situations, service should be resolved from <wsa:Action>. Consider following scenario:
> - JMS transport is used
> - Sender doesn't and cannot be able to set message header property called SOAPAction
> In this case, service is not found as AddressingBasedDispatcher doesn't check <wsa:Action> field.
> I've added <wsa:Action> check to AddressingBasedDispatcher::findService() and successfully used over my custom JMS transport listener(Please look at AXIS2-1585 for more details regarding MDB based JMS transport.)
> Regards,
> Ali Sadik Kumlali
> P.S.: Patch was created under ...\branches\1_1\modules\kernel\src\org\apache\axis2\engine
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-1834) AddressingBasedDispatcher doesn't
dispatch according to the wsa:Action
Posted by "David Illsley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-1834?page=comments#action_12456107 ]
David Illsley commented on AXIS2-1834:
--------------------------------------
OK. I'm totally in favour of a fix for AXIS2-1665 but totally against the approach put forward in this issue which I think would have a serious, negative impact on non-JMS services.
Not knowing much about JMS at all, the proposals put forward in AXIS2-1665 seem don't seem too complex. Are you able to work on them instead?
David
> AddressingBasedDispatcher doesn't dispatch according to the wsa:Action
> ----------------------------------------------------------------------
>
> Key: AXIS2-1834
> URL: http://issues.apache.org/jira/browse/AXIS2-1834
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.1
> Environment: Not important
> Reporter: Ali Sadik Kumlali
> Attachments: patch.txt
>
>
> AddressingBasedDispatcher only looks at <wsa:To> field. But in some situations, service should be resolved from <wsa:Action>. Consider following scenario:
> - JMS transport is used
> - Sender doesn't and cannot be able to set message header property called SOAPAction
> In this case, service is not found as AddressingBasedDispatcher doesn't check <wsa:Action> field.
> I've added <wsa:Action> check to AddressingBasedDispatcher::findService() and successfully used over my custom JMS transport listener(Please look at AXIS2-1585 for more details regarding MDB based JMS transport.)
> Regards,
> Ali Sadik Kumlali
> P.S.: Patch was created under ...\branches\1_1\modules\kernel\src\org\apache\axis2\engine
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-1834) AddressingBasedDispatcher doesn't
dispatch according to the wsa:Action
Posted by "Ali Sadik Kumlali (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-1834?page=comments#action_12456313 ]
Ali Sadik Kumlali commented on AXIS2-1834:
------------------------------------------
Yes, I would rather look into the real problem. But, AFAIK, SOAP/JMS implementation is not standardized yet[1] and it is unknown how and where to put service name in ERP.
BTW, it would not be a problem if we ignore this issue in favour of AXIS2-1665.
Regards,
Ali Sadik Kumlali
[1] http://www.mail-archive.com/axis-dev@ws.apache.org/msg23954.html
> AddressingBasedDispatcher doesn't dispatch according to the wsa:Action
> ----------------------------------------------------------------------
>
> Key: AXIS2-1834
> URL: http://issues.apache.org/jira/browse/AXIS2-1834
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.1
> Environment: Not important
> Reporter: Ali Sadik Kumlali
> Attachments: patch.txt
>
>
> AddressingBasedDispatcher only looks at <wsa:To> field. But in some situations, service should be resolved from <wsa:Action>. Consider following scenario:
> - JMS transport is used
> - Sender doesn't and cannot be able to set message header property called SOAPAction
> In this case, service is not found as AddressingBasedDispatcher doesn't check <wsa:Action> field.
> I've added <wsa:Action> check to AddressingBasedDispatcher::findService() and successfully used over my custom JMS transport listener(Please look at AXIS2-1585 for more details regarding MDB based JMS transport.)
> Regards,
> Ali Sadik Kumlali
> P.S.: Patch was created under ...\branches\1_1\modules\kernel\src\org\apache\axis2\engine
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Assigned: (AXIS2-1834) AddressingBasedDispatcher doesn't
dispatch according to the wsa:Action
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Davanum Srinivas reassigned AXIS2-1834:
---------------------------------------
Assignee: David Illsley
David,
could you please take a look at this issue?
thanks,
dims
> AddressingBasedDispatcher doesn't dispatch according to the wsa:Action
> ----------------------------------------------------------------------
>
> Key: AXIS2-1834
> URL: https://issues.apache.org/jira/browse/AXIS2-1834
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.1
> Environment: Not important
> Reporter: Ali Sadik Kumlali
> Assigned To: David Illsley
> Attachments: patch.txt
>
>
> AddressingBasedDispatcher only looks at <wsa:To> field. But in some situations, service should be resolved from <wsa:Action>. Consider following scenario:
> - JMS transport is used
> - Sender doesn't and cannot be able to set message header property called SOAPAction
> In this case, service is not found as AddressingBasedDispatcher doesn't check <wsa:Action> field.
> I've added <wsa:Action> check to AddressingBasedDispatcher::findService() and successfully used over my custom JMS transport listener(Please look at AXIS2-1585 for more details regarding MDB based JMS transport.)
> Regards,
> Ali Sadik Kumlali
> P.S.: Patch was created under ...\branches\1_1\modules\kernel\src\org\apache\axis2\engine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-1834) AddressingBasedDispatcher doesn't
dispatch according to the wsa:Action
Posted by "David Illsley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Illsley resolved AXIS2-1834.
----------------------------------
Resolution: Won't Fix
I don't believe that dispatching the service based on the action is the correct way to go for a couple of reasons. The most important one is that that would requires actions to be unique over the full set of services deployed which simply isn't possible once you introduce standard actions e.g. with WS-RM, WS-Transfer etc.
A better solution would be to include the service name in a JMS header as suggested by section 2.3.3 of the SOAP/JMS proposal sent out by glen daniels [1]:
[Definition: soapjms:targetService] (xsd:string)
* Used by the service implementation to dispatch the service request.
*optional in IRI
* if specified MUST appear in the JMS message in the JMS property named SOAPJMS_targetService.
If you want to have a further discussion about doing service dispatch on the action, please raise it as a proposal on the axis-dev mailing list.
Thanks,
David
[1] http://marc.theaimsgroup.com/?l=axis-dev&m=116860712209251
> AddressingBasedDispatcher doesn't dispatch according to the wsa:Action
> ----------------------------------------------------------------------
>
> Key: AXIS2-1834
> URL: https://issues.apache.org/jira/browse/AXIS2-1834
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.1
> Environment: Not important
> Reporter: Ali Sadik Kumlali
> Assigned To: David Illsley
> Attachments: patch.txt
>
>
> AddressingBasedDispatcher only looks at <wsa:To> field. But in some situations, service should be resolved from <wsa:Action>. Consider following scenario:
> - JMS transport is used
> - Sender doesn't and cannot be able to set message header property called SOAPAction
> In this case, service is not found as AddressingBasedDispatcher doesn't check <wsa:Action> field.
> I've added <wsa:Action> check to AddressingBasedDispatcher::findService() and successfully used over my custom JMS transport listener(Please look at AXIS2-1585 for more details regarding MDB based JMS transport.)
> Regards,
> Ali Sadik Kumlali
> P.S.: Patch was created under ...\branches\1_1\modules\kernel\src\org\apache\axis2\engine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-1834) AddressingBasedDispatcher doesn't
dispatch according to the wsa:Action
Posted by "David Illsley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-1834?page=comments#action_12456045 ]
David Illsley commented on AXIS2-1834:
--------------------------------------
Hi,
Thanks for the patch. I've had a quick look and have a couple of thoughts:
1. Why is service dispatch based on wsa:To followed by operation dispatch based on wsa:Action not appropriate?
2. If we do this we effectively introduce a new restriction of actions having to be unique across all services (I'm not sure this is practical)
3. If we do this I think we'd need to take a different approach as iterating like that is probably pretty slow.
David
> AddressingBasedDispatcher doesn't dispatch according to the wsa:Action
> ----------------------------------------------------------------------
>
> Key: AXIS2-1834
> URL: http://issues.apache.org/jira/browse/AXIS2-1834
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: kernel
> Affects Versions: 1.1
> Environment: Not important
> Reporter: Ali Sadik Kumlali
> Attachments: patch.txt
>
>
> AddressingBasedDispatcher only looks at <wsa:To> field. But in some situations, service should be resolved from <wsa:Action>. Consider following scenario:
> - JMS transport is used
> - Sender doesn't and cannot be able to set message header property called SOAPAction
> In this case, service is not found as AddressingBasedDispatcher doesn't check <wsa:Action> field.
> I've added <wsa:Action> check to AddressingBasedDispatcher::findService() and successfully used over my custom JMS transport listener(Please look at AXIS2-1585 for more details regarding MDB based JMS transport.)
> Regards,
> Ali Sadik Kumlali
> P.S.: Patch was created under ...\branches\1_1\modules\kernel\src\org\apache\axis2\engine
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org