You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "scwhittle (via GitHub)" <gi...@apache.org> on 2023/03/22 13:53:39 UTC
[GitHub] [beam] scwhittle opened a new pull request, #25930: Optimize counters by reducing allocations
scwhittle opened a new pull request, #25930:
URL: https://github.com/apache/beam/pull/25930
- use forEach instead of requiring Iterator/UnmodifiableIterator overhead
- optimize shortId cache hasing by just using MetricName as stepName is fixed
- reduce MetricKey objects
- avoid MetricsUpdate construction in getMonitoringData by directly processing maps
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #25930: Optimize counters by reducing allocations
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on PR #25930:
URL: https://github.com/apache/beam/pull/25930#issuecomment-1506082981
run dataflow java postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #25930: Optimize counters by reducing allocations
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on PR #25930:
URL: https://github.com/apache/beam/pull/25930#issuecomment-1506082659
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #25930: Optimize counters by reducing allocations
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on PR #25930:
URL: https://github.com/apache/beam/pull/25930#issuecomment-1505581473
run dataflow postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax merged pull request #25930: Optimize counters by reducing allocations
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax merged PR #25930:
URL: https://github.com/apache/beam/pull/25930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #25930: Optimize counters by reducing allocations
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on PR #25930:
URL: https://github.com/apache/beam/pull/25930#issuecomment-1506498569
Failing test is [org.apache.beam.sdk.io.gcp.spanner.SpannerReadIT.testReadWithDataBoost](https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Phrase/129/testReport/org.apache.beam.sdk.io.gcp.spanner/SpannerReadIT/testReadWithDataBoost/)
and is failing with some unrelated project permissions issue for DataBoost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #25930: Optimize counters by reducing allocations
Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on PR #25930:
URL: https://github.com/apache/beam/pull/25930#issuecomment-1482036439
R: @reuvenlax
Saw a 1% total decrease for SDK in metrics related CPU for a nexmark pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25930: Optimize counters by reducing allocations
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25930:
URL: https://github.com/apache/beam/pull/25930#issuecomment-1482037347
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #25930: Optimize counters by reducing allocations
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on PR #25930:
URL: https://github.com/apache/beam/pull/25930#issuecomment-1506083718
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #25930: Optimize counters by reducing allocations
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on PR #25930:
URL: https://github.com/apache/beam/pull/25930#issuecomment-1505581225
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org