You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/28 04:34:02 UTC
[GitHub] [spark] xuanyuanking opened a new pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
xuanyuanking opened a new pull request #28937:
URL: https://github.com/apache/spark/pull/28937
### What changes were proposed in this pull request?
Bug fix for overflow case in `UTF8String.substringSQL`.
### Why are the changes needed?
SQL query `SELECT SUBSTRING("abc", -1207959552, -1207959552)` incorrectly returns` "abc"` against expected output of `""`. For query `SUBSTRING("abc", -100, -100)`, we'll get the right output of `""`.
### Does this PR introduce _any_ user-facing change?
Yes, bug fix for the overflow case.
### How was this patch tested?
New UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28937: [SPARK-32115][SQL] Fix SUBSTRING to handle integer overflows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28937:
URL: https://github.com/apache/spark/pull/28937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28937: [SPARK-32115][SQL] Fix SUBSTRING to handle integer overflows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650810999
cc @gatorsmile , too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650708234
**[Test build #124593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124593/testReport)** for PR 28937 at commit [`5f109a8`](https://github.com/apache/spark/commit/5f109a87bcdadf693352f995bab0e72faf360824).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #28937:
URL: https://github.com/apache/spark/pull/28937#discussion_r446612673
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -341,8 +341,17 @@ public UTF8String substringSQL(int pos, int length) {
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
+ // `len + pos` does not overflow as `len >= 0`.
int start = (pos > 0) ? pos -1 : ((pos < 0) ? len + pos : 0);
- int end = (length == Integer.MAX_VALUE) ? len : start + length;
Review comment:
Sure, added in 4dcfe81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650708381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124593/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650728603
**[Test build #124596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124596/testReport)** for PR 28937 at commit [`4dcfe81`](https://github.com/apache/spark/commit/4dcfe814d319ef9f04c9148bf9c82a9df191ac8c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk commented on a change in pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #28937:
URL: https://github.com/apache/spark/pull/28937#discussion_r446631830
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -341,8 +341,17 @@ public UTF8String substringSQL(int pos, int length) {
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
+ // `len + pos` does not overflow as `len >= 0`.
Review comment:
I made misunderstaning. Thank you for clarification and adding a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650694350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650694181
**[Test build #124593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124593/testReport)** for PR 28937 at commit [`5f109a8`](https://github.com/apache/spark/commit/5f109a87bcdadf693352f995bab0e72faf360824).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650694350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650708378
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650694181
**[Test build #124593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124593/testReport)** for PR 28937 at commit [`5f109a8`](https://github.com/apache/spark/commit/5f109a87bcdadf693352f995bab0e72faf360824).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28937: [SPARK-32115][SQL] Fix SUBSTRING to handle integer overflows
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650814599
cc @dbtsai since this is another correctness issue for all Spark releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk commented on a change in pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #28937:
URL: https://github.com/apache/spark/pull/28937#discussion_r446608738
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -341,8 +341,17 @@ public UTF8String substringSQL(int pos, int length) {
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
+ // `len + pos` does not overflow as `len >= 0`.
Review comment:
What happens if `len = 10` and `pos = Integer.MIN_VALUE`. I guess that `start` would have an incorrect value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #28937:
URL: https://github.com/apache/spark/pull/28937#discussion_r446612715
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -341,8 +341,17 @@ public UTF8String substringSQL(int pos, int length) {
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
+ // `len + pos` does not overflow as `len >= 0`.
int start = (pos > 0) ? pos -1 : ((pos < 0) ? len + pos : 0);
- int end = (length == Integer.MAX_VALUE) ? len : start + length;
+
+ int end;
+ if((long) start + length > Integer.MAX_VALUE) {
Review comment:
Ah thanks, done in 4dcfe81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #28937: [SPARK-32115][SQL] Fix SUBSTRING to handle integer overflows
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #28937:
URL: https://github.com/apache/spark/pull/28937#discussion_r447484628
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -341,8 +341,17 @@ public UTF8String substringSQL(int pos, int length) {
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
+ // `len + pos` does not overflow as `len >= 0`.
Review comment:
Thanks for reviewing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650710917
**[Test build #124596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124596/testReport)** for PR 28937 at commit [`4dcfe81`](https://github.com/apache/spark/commit/4dcfe814d319ef9f04c9148bf9c82a9df191ac8c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650728845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650708378
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650728845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650711072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on a change in pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on a change in pull request #28937:
URL: https://github.com/apache/spark/pull/28937#discussion_r446613486
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -341,8 +341,17 @@ public UTF8String substringSQL(int pos, int length) {
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
+ // `len + pos` does not overflow as `len >= 0`.
Review comment:
The negative `pos` here `refers to the -ith element before the end of the sequence`, so if pos = Integer.MIN_VALUE, then the start should be `pos + len`. The final result of `EMPTY_UTF8` will be returned by `substring` when its param start and until are both negative. I also added a UT in 4dcfe81.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28937:
URL: https://github.com/apache/spark/pull/28937#discussion_r446606269
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -341,8 +341,17 @@ public UTF8String substringSQL(int pos, int length) {
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
+ // `len + pos` does not overflow as `len >= 0`.
int start = (pos > 0) ? pos -1 : ((pos < 0) ? len + pos : 0);
- int end = (length == Integer.MAX_VALUE) ? len : start + length;
Review comment:
Nice catch! Could you add some tests in `UTF8StringSuite`, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk commented on a change in pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #28937:
URL: https://github.com/apache/spark/pull/28937#discussion_r446607693
##########
File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -341,8 +341,17 @@ public UTF8String substringSQL(int pos, int length) {
// to the -ith element before the end of the sequence. If a start index i is 0, it
// refers to the first element.
int len = numChars();
+ // `len + pos` does not overflow as `len >= 0`.
int start = (pos > 0) ? pos -1 : ((pos < 0) ? len + pos : 0);
- int end = (length == Integer.MAX_VALUE) ? len : start + length;
+
+ int end;
+ if((long) start + length > Integer.MAX_VALUE) {
Review comment:
nit: `if ((long) start ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650710917
**[Test build #124596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124596/testReport)** for PR 28937 at commit [`4dcfe81`](https://github.com/apache/spark/commit/4dcfe814d319ef9f04c9148bf9c82a9df191ac8c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650693563
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xuanyuanking commented on pull request #28937: [SPARK-32115][SQL] Fix SUBSTRING to handle integer overflows
Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-651619834
Thank you for reviewing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28937: [SPARK-32115][SQL] Incorrect results for SUBSTRING when overflow
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28937:
URL: https://github.com/apache/spark/pull/28937#issuecomment-650711072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org