[GitHub] [incubator-doris] morningman commented on a change in pull request #4034: [Bug][Broker] Fix bug that the error exception is not caught when closing the broker writer

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4034:
URL: https://github.com/apache/incubator-doris/pull/4034#discussion_r450629168



##########
File path: fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##########
@@ -586,6 +586,8 @@ public void closeReader(TBrokerFD fd) {
                 fsDataInputStream.close();
             } catch (IOException e) {
                 logger.error("errors while close file input stream", e);
+                throw new BrokerException(TBrokerOperationStatusCode.TARGET_STORAGE_SERVICE_ERROR,
+                        e, "errors while close file input stream");

Review comment:
       Not because an empty file was uploaded, but because the uploaded file was not closed properly, resulting in an empty file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org