[GitHub] spark pull request #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in ...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18447#discussion_r125195855
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -209,6 +209,18 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSQLContext {
           Row(2743272264L, 2180413220L))
       }
     
    +  test("misc data_type function") {
    +    val df = Seq(("a", false)).toDF("a", "b")
    +
    +    checkAnswer(
    +      df.select(data_type($"a"), data_type($"b")),
    --- End diff --
    
    For me, it sounds the point is to know where it is `null`. I think it'd be more persuasive if you leave some links here with other equivalent SQL function in other databases and match the behaviour.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org