[jira] [Commented] (PHOENIX-6658) Replace HRegion.get() calls

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499712#comment-17499712 ] 

ASF GitHub Bot commented on PHOENIX-6658:
-----------------------------------------

joshelser commented on a change in pull request #1398:
URL: https://github.com/apache/phoenix/pull/1398#discussion_r816865147



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
##########
@@ -601,7 +602,12 @@ public static void wrapResultUsingOffset(final RegionCoprocessorEnvironment envi
             Result joinResult = null;
             if (ScanUtil.isLocalIndex(scan)) {
                 if (dataRegion != null) {
-                    joinResult = dataRegion.get(get);
+                    try (RegionScanner scanner = dataRegion.getScanner(new Scan(get))) {
+                        List<Cell> cells = new ArrayList<>();
+                        PhoenixKeyValueUtil.maybeCopyCellList(cells);
+                        scanner.next(cells);

Review comment:
       This looks funky :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Replace HRegion.get() calls
> ---------------------------
>
>                 Key: PHOENIX-6658
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6658
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> HBASE-26036 made a change where Region.get() always clones Off-Heap cells before returning them.
> In HBase all non-test occurances of this code were changed to create their own RegionScanner to avoid copying the off-heap cells. We should do the same.
> This would also let Phoenix run correctly with HBase 2.4.5-2.4.9 , as the fix in HBASE-26036 seems to have introduced another bug, HBASE-26777, which causes failures in Phoenix.
> Without this change, Phoenix needs an HBase version that has the fix for HBASE-26777 (Hopefully 2.4.10 or 2.4.11).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)