You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ramkumar Ramachandra <ar...@gmail.com> on 2010/12/01 05:18:37 UTC
Re: [PATCH] Fix Makefile.svn to build APR with threads
Hi Stefan,
Thanks for the suggestions. How about this?
[[[
Makefile.svn: Optionally allow building with threading support
* tools/dev/unix-build/Makefile.svn: Add a new THREADING variable to
control whether APR and sqlite should be built with threading
support.
Suggested by: stsp
Review by: stsp
]]]
Index: tools/dev/unix-build/Makefile.svn
===================================================================
--- tools/dev/unix-build/Makefile.svn (revision 1040690)
+++ tools/dev/unix-build/Makefile.svn (working copy)
@@ -233,6 +233,12 @@
fi
touch $@
+ifdef THREADING
+THREADS_FLAG=--enable-threads
+else
+THREADS_FLAG=--disable-threads
+endif
+
# configure apr
$(APR_OBJDIR)/.configured: $(APR_OBJDIR)/.retrieved
cp $(APR_SRCDIR)/build/apr_hints.m4 \
@@ -246,7 +252,7 @@
$(APR_SRCDIR)/configure \
--prefix=$(PREFIX)/apr \
--enable-maintainer-mode \
- --disable-threads
+ $(THREADS_FLAG)
touch $@
# compile apr
@@ -704,6 +710,12 @@
tar -C $(SRCDIR) -zxf $(DISTDIR)/$(SQLITE_DIST)
touch $@
+ifdef THREADING
+THREADSAFE_FLAG=--enable-threadsafe
+else
+THREADSAFE_FLAG=--disable-threadsafe
+endif
+
# configure sqlite
$(SQLITE_OBJDIR)/.configured: $(SQLITE_OBJDIR)/.retrieved
cd $(SQLITE_OBJDIR) \
@@ -711,7 +723,7 @@
$(SQLITE_SRCDIR)/configure \
--prefix=$(PREFIX)/sqlite \
--disable-tcl \
- --disable-threadsafe
+ $(THREADSAFE_FLAG)
touch $@
# compile sqlite
Re: [PATCH] Fix Makefile.svn to build APR with threads
Posted by Stefan Sperling <st...@elego.de>.
On Wed, Dec 01, 2010 at 10:48:37AM +0530, Ramkumar Ramachandra wrote:
> Hi Stefan,
>
> Thanks for the suggestions. How about this?
+1
A single 'Approved by: stsp' line in the log message is sufficient,
you don't necessarily need the 'suggested' and 'review' lines.
Thanks!
>
> [[[
> Makefile.svn: Optionally allow building with threading support
>
> * tools/dev/unix-build/Makefile.svn: Add a new THREADING variable to
> control whether APR and sqlite should be built with threading
> support.
>
> Suggested by: stsp
> Review by: stsp
> ]]]
>
> Index: tools/dev/unix-build/Makefile.svn
> ===================================================================
> --- tools/dev/unix-build/Makefile.svn (revision 1040690)
> +++ tools/dev/unix-build/Makefile.svn (working copy)
> @@ -233,6 +233,12 @@
> fi
> touch $@
>
> +ifdef THREADING
> +THREADS_FLAG=--enable-threads
> +else
> +THREADS_FLAG=--disable-threads
> +endif
> +
> # configure apr
> $(APR_OBJDIR)/.configured: $(APR_OBJDIR)/.retrieved
> cp $(APR_SRCDIR)/build/apr_hints.m4 \
> @@ -246,7 +252,7 @@
> $(APR_SRCDIR)/configure \
> --prefix=$(PREFIX)/apr \
> --enable-maintainer-mode \
> - --disable-threads
> + $(THREADS_FLAG)
> touch $@
>
> # compile apr
> @@ -704,6 +710,12 @@
> tar -C $(SRCDIR) -zxf $(DISTDIR)/$(SQLITE_DIST)
> touch $@
>
> +ifdef THREADING
> +THREADSAFE_FLAG=--enable-threadsafe
> +else
> +THREADSAFE_FLAG=--disable-threadsafe
> +endif
> +
> # configure sqlite
> $(SQLITE_OBJDIR)/.configured: $(SQLITE_OBJDIR)/.retrieved
> cd $(SQLITE_OBJDIR) \
> @@ -711,7 +723,7 @@
> $(SQLITE_SRCDIR)/configure \
> --prefix=$(PREFIX)/sqlite \
> --disable-tcl \
> - --disable-threadsafe
> + $(THREADSAFE_FLAG)
> touch $@
>
> # compile sqlite