[GitHub] [calcite] vlsi commented on issue #1638: [CALCITE-3540] FoodmartTest produces many warnings due to incorrect use of CalciteAssert.pooled()

[GitBox <gi...@apache.org>]

vlsi commented on issue #1638: [CALCITE-3540] FoodmartTest produces many warnings due to incorrect use of CalciteAssert.pooled()
URL: https://github.com/apache/calcite/pull/1638#issuecomment-562641415
 
 
   Looks like the fix helps.
   
   Then there's a lot of tests that exceed 2 seconds:
   
   ```
             4.4sec, org.apache.calcite.test.FoodmartTest > test(FoodmartQuery)[697], [697] org.apache.calcite.test.FoodMartQuerySet$FoodmartQuery@427aaf71
             3.4sec, org.apache.calcite.test.FoodmartTest > test(FoodmartQuery)[710], [710] org.apache.calcite.test.FoodMartQuerySet$FoodmartQuery@40dabee9
             3.6sec, org.apache.calcite.test.FoodmartTest > test(FoodmartQuery)[716], [716] org.apache.calcite.test.FoodMartQuerySet$FoodmartQuery@46f6dcf2
   ```
   
   It would be nice to add `toString()` to `FoodMartQuerySet$FoodmartQuery` so we could know which tests are slow, and the output would become a bit more compact.
   
   On top of that, there's an option to add `-PslowTestLogThreshold=5000` for slow_tests job, however, I am not sure if we want to go that way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services