You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/02 06:19:05 UTC

[kudu-CR] WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

Hello David Ribeiro Alves,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5323

to review the following change.

Change subject: WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock
......................................................................

WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

WIP because it seems to fail tests when looped, not sure if it's a
regression

Change-Id: Ide22d8ca632672111296cc210c212b87c33d6a0a
---
M src/kudu/rpc/result_tracker.cc
1 file changed, 74 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/5323/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide22d8ca632672111296cc210c212b87c33d6a0a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock
......................................................................


Patch Set 1:

which tests does it fail?

-- 
To view, visit http://gerrit.cloudera.org:8080/5323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide22d8ca632672111296cc210c212b87c33d6a0a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock
......................................................................


Patch Set 1:

I looped the exactly_once_rpc-test and the GC stress test occasionally failed with 'stale' responses. I didn't check if it's already doing that on master, though, yet

-- 
To view, visit http://gerrit.cloudera.org:8080/5323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide22d8ca632672111296cc210c212b87c33d6a0a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.

Change subject: WIP: KUDU-1622. Try to move heavy work out of ResultTracker lock
......................................................................


Abandoned

ended up doing this here: https://gerrit.cloudera.org/#/c/5359/

-- 
To view, visit http://gerrit.cloudera.org:8080/5323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ide22d8ca632672111296cc210c212b87c33d6a0a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>