You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/11/11 14:15:26 UTC
[GitHub] [hive] kasakrisz opened a new pull request #2778: HIVE-25610: Handle partition field comments for Iceberg tables ADDENDUM
kasakrisz opened a new pull request #2778:
URL: https://github.com/apache/hive/pull/2778
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Add the following constants to `serde/if/serde.thrift`
```
const string LIST_COLUMN_COMMENTS = "columns.comments";
const string LIST_PARTITION_COLUMN_COMMENTS = "partition.columns.comments";
```
### Why are the changes needed?
Constants are introduced in #2715 but not added to `serde.thrift`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local -Drat.skip
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz merged pull request #2778: HIVE-25610: Handle partition field comments for Iceberg tables ADDENDUM
Posted by GitBox <gi...@apache.org>.
kasakrisz merged pull request #2778:
URL: https://github.com/apache/hive/pull/2778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on pull request #2778: HIVE-25610: Handle partition field comments for Iceberg tables ADDENDUM
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on pull request #2778:
URL: https://github.com/apache/hive/pull/2778#issuecomment-966545747
Thanks for review @pvary !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2778: HIVE-25610: Handle partition field comments for Iceberg tables ADDENDUM
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2778:
URL: https://github.com/apache/hive/pull/2778#issuecomment-966363636
Thanks for finding this @kasakrisz!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org