You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/10 01:43:21 UTC
[GitHub] [beam] youngoli opened a new pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
youngoli opened a new pull request #13518:
URL: https://github.com/apache/beam/pull/13518
Merges the ValidatesRunner tests (basically just cross-language) and framework with the existing integration test code and adds the ability to filter/sickbay tests. Adjusts existing integration tests to also work with the new framework. Finally, adds gradle targets for running the script with Spark and Python Portable runners.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a change in pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #13518:
URL: https://github.com/apache/beam/pull/13518#discussion_r542799357
##########
File path: sdks/go/test/integration/xlang/xlang_test.go
##########
@@ -0,0 +1,260 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package validatesrunner
Review comment:
In open source Go the package name practically must match the folder the package lives in, unless it's a package main for a binary. That's probably the source of the pre and post commit failures.
So this would be xlang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #13518:
URL: https://github.com/apache/beam/pull/13518#issuecomment-742178747
Notes:
1. This change is expected to leave existing automated integration tests functionally identical (but it does move the directory of the test driver, so this should probably be tested on the PostCommit to make sure it still works).
2. Currently Flink seems to be failing the Combine and CombineGlobal Xlang tests. Haven't been able to figure out why yet, and I'll do more debugging on it when I come back to work next week, but if it doesn't seem ValidatesRunner related I'll just filter those and fix them later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #13518:
URL: https://github.com/apache/beam/pull/13518#issuecomment-747850531
Run Go PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #13518:
URL: https://github.com/apache/beam/pull/13518#issuecomment-749939403
Run Go PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on a change in pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
youngoli commented on a change in pull request #13518:
URL: https://github.com/apache/beam/pull/13518#discussion_r545467797
##########
File path: sdks/go/test/integration/integration.go
##########
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package integration provides functionality that needs to be shared between all
+// integration tests.
+package integration
+
+import (
+ "fmt"
+ "regexp"
+ "testing"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/testing/ptest"
+)
+
+// Filters for temporarily skipping integration tests. All filters are regex
+// matchers that must match the full name of a test at the point where
+// CheckFilters is called. Multiple tests can be skipped by using regex
+// wildcards. (ex. "TestXLang_.*" filters all tests starting with TestXLang_)
+//
+// It is strongly recommended to include, TODOs, Jira issues, or just comments
+// describing why tests are being skipped.
+
+// sickbay filters tests that fail due to Go SDK errors. These tests will not
+// execute on any runners.
+var sickbay = []string{
+ // TODO(BEAM-11418): These tests are currently failing with the Go SDK.
+ "TestXLang_CoGroupBy",
+ "TestXLang_Multi",
+ "TestXLang_Partition",
+}
+
+// Runner-specific test filters, for features that are not yet supported on
+// specific runners.
+
+var directFilters = []string{
+ // The direct runner does not yet support cross-language.
+ "TestXLang.*",
+}
+
+var portableFilters = []string{}
+
+var flinkFilters = []string{}
+
+var sparkFilters = []string{}
Review comment:
Agreed. Seems like a good idea, but not something to implement right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on a change in pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
youngoli commented on a change in pull request #13518:
URL: https://github.com/apache/beam/pull/13518#discussion_r542881688
##########
File path: sdks/go/test/integration/xlang/xlang_test.go
##########
@@ -0,0 +1,260 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package validatesrunner
Review comment:
Whoops, forgot to change that when I copied the file over. Ack.
##########
File path: sdks/go/test/integration/xlang/xlang_test.go
##########
@@ -0,0 +1,260 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package validatesrunner
Review comment:
Whoops, forgot to change that when I copied the file over. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli merged pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
youngoli merged pull request #13518:
URL: https://github.com/apache/beam/pull/13518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #13518:
URL: https://github.com/apache/beam/pull/13518#issuecomment-742178788
R: @lostluck
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] youngoli commented on pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
youngoli commented on pull request #13518:
URL: https://github.com/apache/beam/pull/13518#issuecomment-742178895
Run Go PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a change in pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #13518:
URL: https://github.com/apache/beam/pull/13518#discussion_r542950228
##########
File path: sdks/go/test/integration/integration.go
##########
@@ -0,0 +1,108 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package integration provides functionality that needs to be shared between all
+// integration tests.
+package integration
+
+import (
+ "fmt"
+ "regexp"
+ "testing"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/testing/ptest"
+)
+
+// Filters for temporarily skipping integration tests. All filters are regex
+// matchers that must match the full name of a test at the point where
+// CheckFilters is called. Multiple tests can be skipped by using regex
+// wildcards. (ex. "TestXLang_.*" filters all tests starting with TestXLang_)
+//
+// It is strongly recommended to include, TODOs, Jira issues, or just comments
+// describing why tests are being skipped.
+
+// sickbay filters tests that fail due to Go SDK errors. These tests will not
+// execute on any runners.
+var sickbay = []string{
+ // TODO(BEAM-11418): These tests are currently failing with the Go SDK.
+ "TestXLang_CoGroupBy",
+ "TestXLang_Multi",
+ "TestXLang_Partition",
+}
+
+// Runner-specific test filters, for features that are not yet supported on
+// specific runners.
+
+var directFilters = []string{
+ // The direct runner does not yet support cross-language.
+ "TestXLang.*",
+}
+
+var portableFilters = []string{}
+
+var flinkFilters = []string{}
+
+var sparkFilters = []string{}
Review comment:
We should consider (at some future time) to make these into flags, so they can be overridden as needed.
https://pkg.go.dev/github.com/spf13/pflag#StringSlice
Not super important as someone would still want to edit the default if they're trying to fix/resolve some of these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #13518: [BEAM-11415][BEAM-11416] Move Go ValidatesRunner tests and add filtering
Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #13518:
URL: https://github.com/apache/beam/pull/13518#issuecomment-749198254
Run Go PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org