You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/01 07:49:33 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #19914: Fix mypy errors in airflow utils

uranusjr commented on a change in pull request #19914:
URL: https://github.com/apache/airflow/pull/19914#discussion_r759929084



##########
File path: airflow/utils/dag_cycle_tester.py
##########
@@ -50,8 +50,8 @@ def check_cycle(dag: "DAG") -> None:
     :raises AirflowDagCycleException: If cycle is found in the DAG.
     """
     # default of int is 0 which corresponds to CYCLE_NEW
-    visited = defaultdict(int)
-    path_stack = deque()
+    visited: Dict[str, int] = defaultdict(int)
+    path_stack = deque()  # type: ignore

Review comment:
       Why does this need an ignore? There is `typing.Deque`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org