You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/10/24 11:16:49 UTC

[GitHub] [avro] github-code-scanning[bot] commented on a diff in pull request #1922: AVRO-3649: POC for union type to match default values for any innertype

github-code-scanning[bot] commented on code in PR #1922:
URL: https://github.com/apache/avro/pull/1922#discussion_r1003195828


##########
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##########
@@ -1238,6 +1238,16 @@
       }
     }
 
+    /**
+     * Checks if a JSON value matches the schema.
+     *
+     * @param value a value to check against the schema
+     * @return true if the value is valid according to this schema
+     */
+    public boolean isValidValue(final Object value) {

Review Comment:
   ## Missing Override annotation
   
   This method overrides [Schema.isValidValue](1); it is advisable to add an Override annotation.
   
   [Show more details](https://github.com/apache/avro/security/code-scanning/2925)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org