You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bas Bosman <co...@nazgul.nu> on 2014/02/01 15:48:30 UTC
CB-5625 Outstanding GitHub Pull Requests
While browsing JIRA I came across CB-5625 about implementing a coho
command for listing outstanding pull requests on GitHub.
As Coho is self contained and has a lot of code I can reuse I decided that
it would be a nice issue to try to tackle and get my feet wet.
Pull Request at: https://github.com/apache/cordova-coho/pull/13
As mentioned on the issue, I've added a new coho list-pulls command where
you can specify the repositories and branches to check and it will give
back a sorted (by date modified) list per repository and branch of open
Pull Requests.
Example usages:
node C:\GitHub\cordova-coho\coho list-pulls -r auto -b master
node C:\GitHub\cordova-coho\coho list-pulls -r plugins -b dev
GitHub imposes a rate limit of 60 request in an hour. Each repository and
branch combination amounts to a request, so if you specify a '-r all' it
could go fast. The code will fail gracefully if that limit is reached
though.
An example output of the command coho list-pulls -r cordova-coho would be:
.// ========================== Found 2 Pull Requests for repo
"cordova-coho" and branch "master"
-----------------------------------------------------------------------------------------------
Pull Request number 13 for cordova-coho on branch master (Last modified:
2014-02-01T14:23:37Z)
-----------------------------------------------------------------------------------------------
Title: CB-5625 Show open Pull Requests on GitHub
Author: BBosman
Url: https://api.github.com/repos/apache/cordova-coho/pulls/13
-----------------------------------------------------------------------------------------------
Pull Request number 10 for cordova-coho on branch master (Last modified:
2013-12-13T14:49:24Z)
-----------------------------------------------------------------------------------------------
Title: CB-5312 Support github.com/apache repositories
Author: jsoref
Url: https://api.github.com/repos/apache/cordova-coho/pulls/10
What do you guys think?
Bas
Re: CB-5625 Outstanding GitHub Pull Requests
Posted by Andrew Grieve <ag...@chromium.org>.
Finally finished going through all non-tizen, non-WP, non-BB PRs. Highly
encourage others to try this out.
On Mon, Feb 10, 2014 at 4:33 PM, Andrew Grieve <ag...@chromium.org> wrote:
> Been using this Friday / today and am LOVING IT!!!!
>
> So much faster to discover & process PRs.
>
> I've been going through and merging things. I've ignored those on WP,
> Tizen, and BB. If someone could look at those, that would be great!
>
>
> On Sat, Feb 1, 2014 at 12:23 PM, Bas Bosman <co...@nazgul.nu> wrote:
>
>> Hi Ian,
>>
>> Thanks for your response. It's an oversight on my part that you get the
>> JSON representation. I've updated my code to return the normal HTML url.
>>
>> I was able to rebase my change, but something went wrong with the Pull
>> Request, so I had to make a new one:
>> https://github.com/apache/cordova-coho/pull/14
>>
>> Bas
>>
>> > That's great!
>> >
>> > I haven't looked at the code yet, but is there a reason that the output
>> > contains urls that point to the JSON representation of the pull request,
>> > (/pulls/), rather than the human-readable site (/pull/)?
>> >
>> > Is there something useful that a committer could do with the JSON URL?
>> >
>> > Ian
>> >
>> > On Saturday, February 1, 2014, Bas Bosman <co...@nazgul.nu> wrote:
>> >
>> >> While browsing JIRA I came across CB-5625 about implementing a coho
>> >> command for listing outstanding pull requests on GitHub.
>> >>
>> >> As Coho is self contained and has a lot of code I can reuse I decided
>> >> that
>> >> it would be a nice issue to try to tackle and get my feet wet.
>> >>
>> >> Pull Request at: https://github.com/apache/cordova-coho/pull/13
>> >>
>> >> As mentioned on the issue, I've added a new coho list-pulls command
>> >> where
>> >> you can specify the repositories and branches to check and it will give
>> >> back a sorted (by date modified) list per repository and branch of open
>> >> Pull Requests.
>> >>
>> >> Example usages:
>> >> node C:\GitHub\cordova-coho\coho list-pulls -r auto -b master
>> >> node C:\GitHub\cordova-coho\coho list-pulls -r plugins -b dev
>> >>
>> >> GitHub imposes a rate limit of 60 request in an hour. Each repository
>> >> and
>> >> branch combination amounts to a request, so if you specify a '-r all'
>> it
>> >> could go fast. The code will fail gracefully if that limit is reached
>> >> though.
>> >>
>> >> An example output of the command coho list-pulls -r cordova-coho would
>> >> be:
>> >>
>> >> .// ========================== Found 2 Pull Requests for repo
>> >> "cordova-coho" and branch "master"
>> >>
>> >>
>> -----------------------------------------------------------------------------------------------
>> >> Pull Request number 13 for cordova-coho on branch master (Last
>> modified:
>> >> 2014-02-01T14:23:37Z)
>> >>
>> >>
>> -----------------------------------------------------------------------------------------------
>> >> Title: CB-5625 Show open Pull Requests on GitHub
>> >> Author: BBosman
>> >> Url: https://api.github.com/repos/apache/cordova-coho/pulls/13
>> >>
>> >>
>> -----------------------------------------------------------------------------------------------
>> >> Pull Request number 10 for cordova-coho on branch master (Last
>> modified:
>> >> 2013-12-13T14:49:24Z)
>> >>
>> >>
>> -----------------------------------------------------------------------------------------------
>> >> Title: CB-5312 Support github.com/apache repositories
>> >> Author: jsoref
>> >> Url: https://api.github.com/repos/apache/cordova-coho/pulls/10
>> >>
>> >>
>> >> What do you guys think?
>> >>
>> >> Bas
>> >>
>> >>
>> >
>>
>>
>>
>
Re: CB-5625 Outstanding GitHub Pull Requests
Posted by Andrew Grieve <ag...@chromium.org>.
Been using this Friday / today and am LOVING IT!!!!
So much faster to discover & process PRs.
I've been going through and merging things. I've ignored those on WP,
Tizen, and BB. If someone could look at those, that would be great!
On Sat, Feb 1, 2014 at 12:23 PM, Bas Bosman <co...@nazgul.nu> wrote:
> Hi Ian,
>
> Thanks for your response. It's an oversight on my part that you get the
> JSON representation. I've updated my code to return the normal HTML url.
>
> I was able to rebase my change, but something went wrong with the Pull
> Request, so I had to make a new one:
> https://github.com/apache/cordova-coho/pull/14
>
> Bas
>
> > That's great!
> >
> > I haven't looked at the code yet, but is there a reason that the output
> > contains urls that point to the JSON representation of the pull request,
> > (/pulls/), rather than the human-readable site (/pull/)?
> >
> > Is there something useful that a committer could do with the JSON URL?
> >
> > Ian
> >
> > On Saturday, February 1, 2014, Bas Bosman <co...@nazgul.nu> wrote:
> >
> >> While browsing JIRA I came across CB-5625 about implementing a coho
> >> command for listing outstanding pull requests on GitHub.
> >>
> >> As Coho is self contained and has a lot of code I can reuse I decided
> >> that
> >> it would be a nice issue to try to tackle and get my feet wet.
> >>
> >> Pull Request at: https://github.com/apache/cordova-coho/pull/13
> >>
> >> As mentioned on the issue, I've added a new coho list-pulls command
> >> where
> >> you can specify the repositories and branches to check and it will give
> >> back a sorted (by date modified) list per repository and branch of open
> >> Pull Requests.
> >>
> >> Example usages:
> >> node C:\GitHub\cordova-coho\coho list-pulls -r auto -b master
> >> node C:\GitHub\cordova-coho\coho list-pulls -r plugins -b dev
> >>
> >> GitHub imposes a rate limit of 60 request in an hour. Each repository
> >> and
> >> branch combination amounts to a request, so if you specify a '-r all' it
> >> could go fast. The code will fail gracefully if that limit is reached
> >> though.
> >>
> >> An example output of the command coho list-pulls -r cordova-coho would
> >> be:
> >>
> >> .// ========================== Found 2 Pull Requests for repo
> >> "cordova-coho" and branch "master"
> >>
> >>
> -----------------------------------------------------------------------------------------------
> >> Pull Request number 13 for cordova-coho on branch master (Last modified:
> >> 2014-02-01T14:23:37Z)
> >>
> >>
> -----------------------------------------------------------------------------------------------
> >> Title: CB-5625 Show open Pull Requests on GitHub
> >> Author: BBosman
> >> Url: https://api.github.com/repos/apache/cordova-coho/pulls/13
> >>
> >>
> -----------------------------------------------------------------------------------------------
> >> Pull Request number 10 for cordova-coho on branch master (Last modified:
> >> 2013-12-13T14:49:24Z)
> >>
> >>
> -----------------------------------------------------------------------------------------------
> >> Title: CB-5312 Support github.com/apache repositories
> >> Author: jsoref
> >> Url: https://api.github.com/repos/apache/cordova-coho/pulls/10
> >>
> >>
> >> What do you guys think?
> >>
> >> Bas
> >>
> >>
> >
>
>
>
Re: CB-5625 Outstanding GitHub Pull Requests
Posted by Bas Bosman <co...@nazgul.nu>.
Hi Ian,
Thanks for your response. It's an oversight on my part that you get the
JSON representation. I've updated my code to return the normal HTML url.
I was able to rebase my change, but something went wrong with the Pull
Request, so I had to make a new one:
https://github.com/apache/cordova-coho/pull/14
Bas
> That's great!
>
> I haven't looked at the code yet, but is there a reason that the output
> contains urls that point to the JSON representation of the pull request,
> (/pulls/), rather than the human-readable site (/pull/)?
>
> Is there something useful that a committer could do with the JSON URL?
>
> Ian
>
> On Saturday, February 1, 2014, Bas Bosman <co...@nazgul.nu> wrote:
>
>> While browsing JIRA I came across CB-5625 about implementing a coho
>> command for listing outstanding pull requests on GitHub.
>>
>> As Coho is self contained and has a lot of code I can reuse I decided
>> that
>> it would be a nice issue to try to tackle and get my feet wet.
>>
>> Pull Request at: https://github.com/apache/cordova-coho/pull/13
>>
>> As mentioned on the issue, I've added a new coho list-pulls command
>> where
>> you can specify the repositories and branches to check and it will give
>> back a sorted (by date modified) list per repository and branch of open
>> Pull Requests.
>>
>> Example usages:
>> node C:\GitHub\cordova-coho\coho list-pulls -r auto -b master
>> node C:\GitHub\cordova-coho\coho list-pulls -r plugins -b dev
>>
>> GitHub imposes a rate limit of 60 request in an hour. Each repository
>> and
>> branch combination amounts to a request, so if you specify a '-r all' it
>> could go fast. The code will fail gracefully if that limit is reached
>> though.
>>
>> An example output of the command coho list-pulls -r cordova-coho would
>> be:
>>
>> .// ========================== Found 2 Pull Requests for repo
>> "cordova-coho" and branch "master"
>>
>> -----------------------------------------------------------------------------------------------
>> Pull Request number 13 for cordova-coho on branch master (Last modified:
>> 2014-02-01T14:23:37Z)
>>
>> -----------------------------------------------------------------------------------------------
>> Title: CB-5625 Show open Pull Requests on GitHub
>> Author: BBosman
>> Url: https://api.github.com/repos/apache/cordova-coho/pulls/13
>>
>> -----------------------------------------------------------------------------------------------
>> Pull Request number 10 for cordova-coho on branch master (Last modified:
>> 2013-12-13T14:49:24Z)
>>
>> -----------------------------------------------------------------------------------------------
>> Title: CB-5312 Support github.com/apache repositories
>> Author: jsoref
>> Url: https://api.github.com/repos/apache/cordova-coho/pulls/10
>>
>>
>> What do you guys think?
>>
>> Bas
>>
>>
>
Re: CB-5625 Outstanding GitHub Pull Requests
Posted by Ian Clelland <ic...@chromium.org>.
That's great!
I haven't looked at the code yet, but is there a reason that the output
contains urls that point to the JSON representation of the pull request,
(/pulls/), rather than the human-readable site (/pull/)?
Is there something useful that a committer could do with the JSON URL?
Ian
On Saturday, February 1, 2014, Bas Bosman <co...@nazgul.nu> wrote:
> While browsing JIRA I came across CB-5625 about implementing a coho
> command for listing outstanding pull requests on GitHub.
>
> As Coho is self contained and has a lot of code I can reuse I decided that
> it would be a nice issue to try to tackle and get my feet wet.
>
> Pull Request at: https://github.com/apache/cordova-coho/pull/13
>
> As mentioned on the issue, I've added a new coho list-pulls command where
> you can specify the repositories and branches to check and it will give
> back a sorted (by date modified) list per repository and branch of open
> Pull Requests.
>
> Example usages:
> node C:\GitHub\cordova-coho\coho list-pulls -r auto -b master
> node C:\GitHub\cordova-coho\coho list-pulls -r plugins -b dev
>
> GitHub imposes a rate limit of 60 request in an hour. Each repository and
> branch combination amounts to a request, so if you specify a '-r all' it
> could go fast. The code will fail gracefully if that limit is reached
> though.
>
> An example output of the command coho list-pulls -r cordova-coho would be:
>
> .// ========================== Found 2 Pull Requests for repo
> "cordova-coho" and branch "master"
>
> -----------------------------------------------------------------------------------------------
> Pull Request number 13 for cordova-coho on branch master (Last modified:
> 2014-02-01T14:23:37Z)
>
> -----------------------------------------------------------------------------------------------
> Title: CB-5625 Show open Pull Requests on GitHub
> Author: BBosman
> Url: https://api.github.com/repos/apache/cordova-coho/pulls/13
>
> -----------------------------------------------------------------------------------------------
> Pull Request number 10 for cordova-coho on branch master (Last modified:
> 2013-12-13T14:49:24Z)
>
> -----------------------------------------------------------------------------------------------
> Title: CB-5312 Support github.com/apache repositories
> Author: jsoref
> Url: https://api.github.com/repos/apache/cordova-coho/pulls/10
>
>
> What do you guys think?
>
> Bas
>
>