You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Tanya-W (via GitHub)" <gi...@apache.org> on 2023/06/02 03:35:36 UTC
[GitHub] [doris] Tanya-W opened a new pull request, #20361: [fix](match) fix match query with compound predicates return -6003
Tanya-W opened a new pull request, #20361:
URL: https://github.com/apache/doris/pull/20361
## Proposed changes
fix match query with compound predicates return -6003
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #20361:
URL: https://github.com/apache/doris/pull/20361#discussion_r1213883693
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -717,10 +717,15 @@ Status SegmentIterator::_apply_index_except_leafnode_of_andnode() {
continue;
}
+ int32_t unique_id = _schema->unique_id(pred->column_id());
+ bool need_remaining_after_evaluate = _column_has_fulltext_index(unique_id) &&
+ PredicateTypeTraits::is_equal_or_list(pred_type);
if (!res.ok()) {
- if ((res.code() == ErrorCode::INVERTED_INDEX_FILE_NOT_FOUND &&
- pred->type() != PredicateType::MATCH) ||
- res.code() == ErrorCode::INVERTED_INDEX_FILE_HIT_LIMIT) {
+ if (res.code() == ErrorCode::INVERTED_INDEX_FILE_NOT_FOUND ||
+ res.code() == ErrorCode::INVERTED_INDEX_FILE_HIT_LIMIT ||
+ res.code() == ErrorCode::INVERTED_INDEX_EVALUATE_SKIPPED ||
+ (res.code() == ErrorCode::INVERTED_INDEX_NO_TERMS &&
+ need_remaining_after_evaluate)) {
Review Comment:
wrap as a function, so _apply_inverted_index_on_column_predicate can also use it, and next time you change your condition, you will not forget that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W commented on PR #20361:
URL: https://github.com/apache/doris/pull/20361#issuecomment-1573235868
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] qidaye merged pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "qidaye (via GitHub)" <gi...@apache.org>.
qidaye merged PR #20361:
URL: https://github.com/apache/doris/pull/20361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20361:
URL: https://github.com/apache/doris/pull/20361#issuecomment-1573172858
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W commented on a diff in pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W commented on code in PR #20361:
URL: https://github.com/apache/doris/pull/20361#discussion_r1213898959
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -717,10 +717,15 @@ Status SegmentIterator::_apply_index_except_leafnode_of_andnode() {
continue;
}
+ int32_t unique_id = _schema->unique_id(pred->column_id());
+ bool need_remaining_after_evaluate = _column_has_fulltext_index(unique_id) &&
+ PredicateTypeTraits::is_equal_or_list(pred_type);
if (!res.ok()) {
- if ((res.code() == ErrorCode::INVERTED_INDEX_FILE_NOT_FOUND &&
- pred->type() != PredicateType::MATCH) ||
- res.code() == ErrorCode::INVERTED_INDEX_FILE_HIT_LIMIT) {
+ if (res.code() == ErrorCode::INVERTED_INDEX_FILE_NOT_FOUND ||
+ res.code() == ErrorCode::INVERTED_INDEX_FILE_HIT_LIMIT ||
+ res.code() == ErrorCode::INVERTED_INDEX_EVALUATE_SKIPPED ||
+ (res.code() == ErrorCode::INVERTED_INDEX_NO_TERMS &&
+ need_remaining_after_evaluate)) {
Review Comment:
you are right, I will update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W commented on PR #20361:
URL: https://github.com/apache/doris/pull/20361#issuecomment-1573096690
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W commented on PR #20361:
URL: https://github.com/apache/doris/pull/20361#issuecomment-1573127528
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Tanya-W commented on a diff in pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "Tanya-W (via GitHub)" <gi...@apache.org>.
Tanya-W commented on code in PR #20361:
URL: https://github.com/apache/doris/pull/20361#discussion_r1213898772
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -717,10 +717,15 @@ Status SegmentIterator::_apply_index_except_leafnode_of_andnode() {
continue;
}
Review Comment:
yes, I will add some regression case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20361:
URL: https://github.com/apache/doris/pull/20361#issuecomment-1573238749
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #20361:
URL: https://github.com/apache/doris/pull/20361#discussion_r1213882269
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -717,10 +717,15 @@ Status SegmentIterator::_apply_index_except_leafnode_of_andnode() {
continue;
}
Review Comment:
maybe we should add some test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20361:
URL: https://github.com/apache/doris/pull/20361#issuecomment-1573097136
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20361: [fix](match) fix match query with compound predicates return -6003
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20361:
URL: https://github.com/apache/doris/pull/20361#issuecomment-1573129269
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org