You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gr...@apache.org on 2023/09/29 17:23:00 UTC
[logging-chainsaw] branch master updated (dfe6fc4 -> b259a4f)
This is an automated email from the ASF dual-hosted git repository.
grobmeier pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/logging-chainsaw.git
from dfe6fc4 made use of better logging syntax
new 576d0ef used generics instead of raw types
new b259a4f removed unnecessary brackets
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../chainsaw/ApplicationPreferenceModelPanel.java | 5 +---
src/main/java/org/apache/log4j/chainsaw/LogUI.java | 27 ++++++++++------------
2 files changed, 13 insertions(+), 19 deletions(-)
[logging-chainsaw] 01/02: used generics instead of raw types
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
grobmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-chainsaw.git
commit 576d0ef0b38a6ee7587041a85c4a96608f9e5155
Author: Christian Grobmeier <cg...@grobmeier.de>
AuthorDate: Fri Sep 29 19:22:29 2023 +0200
used generics instead of raw types
---
src/main/java/org/apache/log4j/chainsaw/LogUI.java | 27 ++++++++++------------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/src/main/java/org/apache/log4j/chainsaw/LogUI.java b/src/main/java/org/apache/log4j/chainsaw/LogUI.java
index 0fcb688..c6dc35a 100644
--- a/src/main/java/org/apache/log4j/chainsaw/LogUI.java
+++ b/src/main/java/org/apache/log4j/chainsaw/LogUI.java
@@ -722,11 +722,11 @@ public class LogUI extends JFrame {
Action showHiddenTabsAction =
new AbstractAction("Show All Hidden") {
public void actionPerformed(ActionEvent e) {
- for (Object o : getPanels().entrySet()) {
- Map.Entry entry = (Map.Entry) o;
- Boolean docked = (Boolean) entry.getValue();
- if (docked) {
- String identifier = (String) entry.getKey();
+
+ for (Map.Entry<String, Boolean> entry : getPanels().entrySet()) {
+ Boolean docked = entry.getValue();
+ if (Boolean.TRUE.equals(docked)) {
+ String identifier = entry.getKey();
int count = getTabbedPane().getTabCount();
boolean found = false;
@@ -735,7 +735,6 @@ public class LogUI extends JFrame {
if (name.equals(identifier)) {
found = true;
-
break;
}
}
@@ -1302,19 +1301,17 @@ public class LogUI extends JFrame {
aboutBox.setVisible(true);
}
- Map getPanels() {
- Map m = new HashMap();
+ Map<String, Boolean> getPanels() {
+ Map<String, Boolean> result = new HashMap<>();
Set<Map.Entry<String, Component>> panelSet = getPanelMap().entrySet();
- for (Object aPanelSet : panelSet) {
- Map.Entry entry = (Map.Entry) aPanelSet;
- Object o = entry.getValue();
- boolean valueToSend;
- valueToSend = !(o instanceof LogPanel) || ((DockablePanel) entry.getValue()).isDocked();
- m.put(entry.getKey(), valueToSend);
+ for (Map.Entry<String, Component> panel : panelSet) {
+ Component component = panel.getValue();
+ boolean value = !(component instanceof LogPanel) || ((DockablePanel) panel.getValue()).isDocked();
+ result.put(panel.getKey(), value);
}
- return m;
+ return result;
}
void displayPanel(String panelName, boolean display) {
[logging-chainsaw] 02/02: removed unnecessary brackets
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
grobmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-chainsaw.git
commit b259a4f8453a575da92c00a707aa02b5e5b756c2
Author: Christian Grobmeier <cg...@grobmeier.de>
AuthorDate: Fri Sep 29 19:22:54 2023 +0200
removed unnecessary brackets
---
.../org/apache/log4j/chainsaw/ApplicationPreferenceModelPanel.java | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/log4j/chainsaw/ApplicationPreferenceModelPanel.java b/src/main/java/org/apache/log4j/chainsaw/ApplicationPreferenceModelPanel.java
index 262891a..a5e61e6 100644
--- a/src/main/java/org/apache/log4j/chainsaw/ApplicationPreferenceModelPanel.java
+++ b/src/main/java/org/apache/log4j/chainsaw/ApplicationPreferenceModelPanel.java
@@ -61,10 +61,7 @@ public class ApplicationPreferenceModelPanel extends AbstractPreferencePanel {
hidePanel();
});
- getCancelButton().addActionListener(
- e -> {
- hidePanel();
- });
+ getCancelButton().addActionListener(e -> hidePanel());
}
public void updateModel(){