You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Nelson Araujo <no...@github.com> on 2017/11/15 20:42:19 UTC
[jclouds/jclouds] JCLOUDS-1355: Enable VM creation without external
IP address. (#1157)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1157
-- Commit Summary --
* JCLOUDS-1355: Enable VM creation without external IP address.
-- File Changes --
M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java (23)
M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/options/GoogleComputeEngineTemplateOptions.java (19)
M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/NewInstance.java (14)
M providers/google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceMockTest.java (52)
A providers/google-compute-engine/src/test/resources/instance_insert_no_ip.json (42)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1157.patch
https://github.com/jclouds/jclouds/pull/1157.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1157
Re: [jclouds/jclouds] JCLOUDS-1355: Enable VM creation without
external IP address. (#1157)
Posted by Ignasi Barrera <no...@github.com>.
Closed #1157.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1157#event-1351520717
Re: [jclouds/jclouds] JCLOUDS-1355: Enable VM creation without
external IP address. (#1157)
Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1157#pullrequestreview-78036013
Re: [jclouds/jclouds] JCLOUDS-1355: Enable VM creation without
external IP address. (#1157)
Posted by Ignasi Barrera <no...@github.com>.
Merged to master as [5d82a3df](http://git-wip-us.apache.org/repos/asf/jclouds/commit/5d82a3df).
Thanks, @nelsonjr!
Although changes are backward-compatible I haven't cherry-picked it to 2.0.x because there are conflicts. 2.0.x only supports legacy networks and there is no a clean merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1157#issuecomment-345960468