You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2021/02/09 12:44:09 UTC

[GitHub] [incubator-sedona] michaelmerg opened a new pull request #508: [SEDONA-14] Fix JSON representation of GeometryUDT schema

michaelmerg opened a new pull request #508:
URL: https://github.com/apache/incubator-sedona/pull/508


   ## Is this PR related to a proposed Issue?
   SEDONA-14
   
   ## What changes were proposed in this PR?
   Fix the JSON representation of the GeometryUDT schema so that it can be parsed by `DataType.fromJson(...)` which is required to write a data frame in Parquet format.
   
   ## How was this patch tested?
   Unit test added
   
   ## Did this PR include necessary documentation updates?
   No documentation update required


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] michaelmerg commented on a change in pull request #508: [SEDONA-14] Fix JSON representation of GeometryUDT schema

Posted by GitBox <gi...@apache.org>.
michaelmerg commented on a change in pull request #508:
URL: https://github.com/apache/incubator-sedona/pull/508#discussion_r573237933



##########
File path: sql/src/test/scala/org/apache/spark/sql/sedona_sql/UDT/GeometryUdtTestScala.scala
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       Sure, I thought to put it in the same package as the GeometryUDT class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #508: [SEDONA-14] Fix JSON representation of GeometryUDT schema

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on a change in pull request #508:
URL: https://github.com/apache/incubator-sedona/pull/508#discussion_r573181886



##########
File path: sql/src/test/scala/org/apache/spark/sql/sedona_sql/UDT/GeometryUdtTestScala.scala
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       Can you please move this test file to the path "org/apache/sedona/sql"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on pull request #508: [SEDONA-14] Fix JSON representation of GeometryUDT schema

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on pull request #508:
URL: https://github.com/apache/incubator-sedona/pull/508#issuecomment-776283573


   @michaelmerg Thanks for your contribution!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu merged pull request #508: [SEDONA-14] Fix JSON representation of GeometryUDT schema

Posted by GitBox <gi...@apache.org>.
jiayuasu merged pull request #508:
URL: https://github.com/apache/incubator-sedona/pull/508


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org