You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by da...@apache.org on 2014/11/08 23:37:19 UTC
svn commit: r1637602 - in /pig/branches/branch-0.14: CHANGES.txt
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java
Author: daijy
Date: Sat Nov 8 22:37:18 2014
New Revision: 1637602
URL: http://svn.apache.org/r1637602
Log:
PIG-4314: BigData_5 hang on some machine
Modified:
pig/branches/branch-0.14/CHANGES.txt
pig/branches/branch-0.14/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java
Modified: pig/branches/branch-0.14/CHANGES.txt
URL: http://svn.apache.org/viewvc/pig/branches/branch-0.14/CHANGES.txt?rev=1637602&r1=1637601&r2=1637602&view=diff
==============================================================================
--- pig/branches/branch-0.14/CHANGES.txt (original)
+++ pig/branches/branch-0.14/CHANGES.txt Sat Nov 8 22:37:18 2014
@@ -101,6 +101,8 @@ OPTIMIZATIONS
BUG FIXES
+PIG-4314: BigData_5 hang on some machine (daijy)
+
PIG-4299: SpillableMemoryManager assumes tenured heap incorrectly (prkommireddi via daijy)
PIG-4298: Descending order-by is broken in some cases when key is bytearrays (cheolsoo)
Modified: pig/branches/branch-0.14/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java
URL: http://svn.apache.org/viewvc/pig/branches/branch-0.14/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java?rev=1637602&r1=1637601&r2=1637602&view=diff
==============================================================================
--- pig/branches/branch-0.14/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java (original)
+++ pig/branches/branch-0.14/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java Sat Nov 8 22:37:18 2014
@@ -202,12 +202,14 @@ public class POPartialAgg extends Physic
// SpillableMemoryManager requested a spill to reduce memory
// consumption. See if we can avoid it.
aggregateBothLevels(false, false);
- if (shouldSpill()) {
- startSpill(false);
- } else {
- LOG.info("Avoided emitting records during spill memory call.");
- doContingentSpill = false;
- }
+ // TODO Need to see if we can optimize here (See PIG-4314)
+ // if (shouldSpill()) {
+ // startSpill(false);
+ // } else {
+ // LOG.info("Avoided emitting records during spill memory call.");
+ // doContingentSpill = false;
+ // }
+ startSpill(false);
}
}
if (doSpill) {