[GitHub] [arrow-rs] alamb commented on a diff in pull request #4285: Only increment metrics for data pages

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4285:
URL: https://github.com/apache/arrow-rs/pull/4285#discussion_r1206572941


##########
parquet/src/file/writer.rs:
##########
@@ -765,10 +764,7 @@ impl<'a, W: Write> PageWriter for SerializedPageWriter<'a, W> {
         spec.compressed_size = compressed_size + header_size;
         spec.offset = start_pos;
         spec.bytes_written = self.sink.bytes_written() as u64 - start_pos;
-        // Number of values is incremented for data pages only

Review Comment:
   So what I am seeing is that this was basically a workaround for the fact that `num_values` was not updated for data pages in `update_metrics_for_page` which has now been fixed. If so that makes sense to me 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org