[jira] [Commented] (AIRFLOW-4560) Tez queue parameter passed by mapred_queue is incorrect

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846251#comment-16846251 ] 

ASF GitHub Bot commented on AIRFLOW-4560:
-----------------------------------------

aliceabe commented on pull request #5315: [AIRFLOW-4560] Fix Tez queue parameter name in mapred_queue
URL: https://github.com/apache/airflow/pull/5315
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-4560) issues and references them in the PR title.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes: 
   
   The Tez configuration parameter passed is incorrect, it should be `tez.queue.name` and not `tez.job.queue.name`.
   See Tez documentation https://tez.apache.org/releases/0.9.2/tez-api-javadocs/configs/TezConfiguration.html
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Only fixing a typo
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
   @krishnabhupatiraju 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Tez queue parameter passed by mapred_queue is incorrect
> -------------------------------------------------------
>
>                 Key: AIRFLOW-4560
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4560
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Alice Berard
>            Priority: Major
>
> The parameter is currently {{tez.job.queue.name}}, see code: [https://github.com/apache/airflow/blob/355bd56282e6a684c5c060953e9948ba2260aa37/airflow/hooks/hive_hooks.py#L214]
> But it should be {{tez.queue.name}}, see here: [https://tez.apache.org/releases/0.9.2/tez-api-javadocs/configs/TezConfiguration.html]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)