You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2022/07/11 15:43:20 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request, #345: Check if to drop stream filters for stream with CLI XML content only
algairim opened a new pull request, #345:
URL: https://github.com/apache/brooklyn-ui/pull/345
Signed-off-by: Mykola Mandra <my...@cloudsoft.io>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] jcabrerizo commented on a diff in pull request #345: Check if to drop stream filters for stream with CLI XML content only
Posted by GitBox <gi...@apache.org>.
jcabrerizo commented on code in PR #345:
URL: https://github.com/apache/brooklyn-ui/pull/345#discussion_r918117843
##########
ui-modules/app-inspector/app/components/stream/stream.template.html:
##########
@@ -19,10 +19,10 @@
<loading-state error="error" ng-if="stream === undefined"></loading-state>
<div ng-show="stream.length >= 0">
- <pre ng-if="stream.length > 0 && !isFormatContent()" class="auto-scrollable">{{stream}}</pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && isFilterContent()" class="auto-scrollable"><pre ng-repeat="item in filteredStream track by item.id" ng-show="isDisplayFormattedItem(item)" class="log-section" ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><p ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning && !isDisplayError && !isDisplayOther" class="text-center"><i>(select filter)</i></p></pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && !isFilterContent()" class="auto-scrollable">{{formattedStream}}</pre>
- <pre ng-if="stream.length == 0" class="text-center"><i>(no content)</i></pre>
+ <pre ng-show="stream.length > 0 && !isFormatContent()" class="auto-scrollable">{{stream}}</pre>
+ <pre ng-show="stream.length > 0 && isFormatContent() && isFilterContent()" class="auto-scrollable"><div ng-if="isFilterContent()"><pre ng-repeat="item in filteredStream track by item.id" ng-show="isDisplayFormattedItem(item)" class="log-section" ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><div><p ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning && !isDisplayError && !isDisplayOther" class="text-center"><i>(select filter)</i></p></pre>
Review Comment:
Is not the second `<div ng-if="isFilterContent()">` redundant as the condition is part of the -now- `ng-show`?
##########
ui-modules/app-inspector/app/components/stream/stream.template.html:
##########
@@ -19,10 +19,10 @@
<loading-state error="error" ng-if="stream === undefined"></loading-state>
<div ng-show="stream.length >= 0">
- <pre ng-if="stream.length > 0 && !isFormatContent()" class="auto-scrollable">{{stream}}</pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && isFilterContent()" class="auto-scrollable"><pre ng-repeat="item in filteredStream track by item.id" ng-show="isDisplayFormattedItem(item)" class="log-section" ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><p ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning && !isDisplayError && !isDisplayOther" class="text-center"><i>(select filter)</i></p></pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && !isFilterContent()" class="auto-scrollable">{{formattedStream}}</pre>
- <pre ng-if="stream.length == 0" class="text-center"><i>(no content)</i></pre>
+ <pre ng-show="stream.length > 0 && !isFormatContent()" class="auto-scrollable">{{stream}}</pre>
+ <pre ng-show="stream.length > 0 && isFormatContent() && isFilterContent()" class="auto-scrollable"><div ng-if="isFilterContent()"><pre ng-repeat="item in filteredStream track by item.id" ng-show="isDisplayFormattedItem(item)" class="log-section" ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><div><p ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning && !isDisplayError && !isDisplayOther" class="text-center"><i>(select filter)</i></p></pre>
Review Comment:
ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim merged pull request #345: Check if to drop stream filters for stream with CLI XML content only
Posted by GitBox <gi...@apache.org>.
algairim merged PR #345:
URL: https://github.com/apache/brooklyn-ui/pull/345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a diff in pull request #345: Check if to drop stream filters for stream with CLI XML content only
Posted by GitBox <gi...@apache.org>.
algairim commented on code in PR #345:
URL: https://github.com/apache/brooklyn-ui/pull/345#discussion_r918122052
##########
ui-modules/app-inspector/app/components/stream/stream.template.html:
##########
@@ -19,10 +19,10 @@
<loading-state error="error" ng-if="stream === undefined"></loading-state>
<div ng-show="stream.length >= 0">
- <pre ng-if="stream.length > 0 && !isFormatContent()" class="auto-scrollable">{{stream}}</pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && isFilterContent()" class="auto-scrollable"><pre ng-repeat="item in filteredStream track by item.id" ng-show="isDisplayFormattedItem(item)" class="log-section" ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><p ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning && !isDisplayError && !isDisplayOther" class="text-center"><i>(select filter)</i></p></pre>
- <pre ng-if="stream.length > 0 && isFormatContent() && !isFilterContent()" class="auto-scrollable">{{formattedStream}}</pre>
- <pre ng-if="stream.length == 0" class="text-center"><i>(no content)</i></pre>
+ <pre ng-show="stream.length > 0 && !isFormatContent()" class="auto-scrollable">{{stream}}</pre>
+ <pre ng-show="stream.length > 0 && isFormatContent() && isFilterContent()" class="auto-scrollable"><div ng-if="isFilterContent()"><pre ng-repeat="item in filteredStream track by item.id" ng-show="isDisplayFormattedItem(item)" class="log-section" ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><div><p ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning && !isDisplayError && !isDisplayOther" class="text-center"><i>(select filter)</i></p></pre>
Review Comment:
No, it is not, this is the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org