You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/24 05:14:37 UTC
[GitHub] [flink] xintongsong opened a new pull request #10672:
[FLINK-15373][core][config
xintongsong opened a new pull request #10672: [FLINK-15373][core][config
URL: https://github.com/apache/flink/pull/10672
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142190064 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142305015 TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3902 TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
Hash:ed7853792489b3a5e492d8529400d779ece938f9 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3904 TriggerType:PUSH TriggerID:ed7853792489b3a5e492d8529400d779ece938f9
Hash:ed7853792489b3a5e492d8529400d779ece938f9 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142305997 TriggerType:PUSH TriggerID:ed7853792489b3a5e492d8529400d779ece938f9
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142190064) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874)
* e9328aa4fdbf2978171da9214bd44a87b7d8e016 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142305015) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3902)
* ed7853792489b3a5e492d8529400d779ece938f9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142305997) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3904)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142190064 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142190064) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142190064 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142190064) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874)
* e9328aa4fdbf2978171da9214bd44a87b7d8e016 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568847383
@zhuzhurk Done rebasing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568846147
@xintongsong #10673 is merged. Would you rebase this PR onto master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568656301
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 31a2ccbabb6675673d445b6a9d258e6622d295d8 (Tue Dec 24 05:17:59 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk merged pull request #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#discussion_r361265641
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -275,8 +276,9 @@
public static final ConfigOption<String> TASK_OFF_HEAP_MEMORY =
key("taskmanager.memory.task.off-heap.size")
.defaultValue("0b")
- .withDescription("Task Heap Memory size for TaskExecutors. This is the size of off heap memory (JVM direct"
- + " memory or native memory) reserved for user code.");
+ .withDescription("Task Off-Heap Memory size for TaskExecutors. This is the size of off heap memory (JVM"
+ + " direct memory and native memory) reserved for user code. The configured value will be fully counted"
Review comment:
Nice catch, thanks. Comment addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568871005
Thanks for addressing the comments @xintongsong .
The change looks good to me. Merging since travis gives green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142190064 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142305015 TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3902 TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
Hash:ed7853792489b3a5e492d8529400d779ece938f9 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3904 TriggerType:PUSH TriggerID:ed7853792489b3a5e492d8529400d779ece938f9
Hash:ed7853792489b3a5e492d8529400d779ece938f9 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142305997 TriggerType:PUSH TriggerID:ed7853792489b3a5e492d8529400d779ece938f9
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142190064) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874)
* e9328aa4fdbf2978171da9214bd44a87b7d8e016 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142305015) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3902)
* ed7853792489b3a5e492d8529400d779ece938f9 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142305997) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3904)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142190064 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142190064) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142190064 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142190064) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142190064 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142305015 TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3902 TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
Hash:ed7853792489b3a5e492d8529400d779ece938f9 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ed7853792489b3a5e492d8529400d779ece938f9
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142190064) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874)
* e9328aa4fdbf2978171da9214bd44a87b7d8e016 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142305015) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3902)
* ed7853792489b3a5e492d8529400d779ece938f9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhuzhurk commented on a change in pull request #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#discussion_r361264512
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -275,8 +276,9 @@
public static final ConfigOption<String> TASK_OFF_HEAP_MEMORY =
key("taskmanager.memory.task.off-heap.size")
.defaultValue("0b")
- .withDescription("Task Heap Memory size for TaskExecutors. This is the size of off heap memory (JVM direct"
- + " memory or native memory) reserved for user code.");
+ .withDescription("Task Off-Heap Memory size for TaskExecutors. This is the size of off heap memory (JVM"
+ + " direct memory and native memory) reserved for user code. The configured value will be fully counted"
Review comment:
I think it should be `for tasks` rather than `for user code`, e.g. it can be used by Flink sql operators or state backends.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#issuecomment-568663425
<!--
Meta data
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142190064 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:31a2ccbabb6675673d445b6a9d258e6622d295d8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874 TriggerType:PUSH TriggerID:31a2ccbabb6675673d445b6a9d258e6622d295d8
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142305015 TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
Hash:e9328aa4fdbf2978171da9214bd44a87b7d8e016 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3902 TriggerType:PUSH TriggerID:e9328aa4fdbf2978171da9214bd44a87b7d8e016
Hash:ed7853792489b3a5e492d8529400d779ece938f9 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3904 TriggerType:PUSH TriggerID:ed7853792489b3a5e492d8529400d779ece938f9
Hash:ed7853792489b3a5e492d8529400d779ece938f9 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142305997 TriggerType:PUSH TriggerID:ed7853792489b3a5e492d8529400d779ece938f9
-->
## CI report:
* 31a2ccbabb6675673d445b6a9d258e6622d295d8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142190064) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3874)
* e9328aa4fdbf2978171da9214bd44a87b7d8e016 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142305015) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3902)
* ed7853792489b3a5e492d8529400d779ece938f9 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142305997) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3904)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services