[jira] [Created] (THRIFT-3066) C++ TDenseProtocol assert modifies instead of checks

["James E. King, III (JIRA)" <ji...@apache.org>]

James E. King, III created THRIFT-3066:
------------------------------------------

             Summary: C++ TDenseProtocol assert modifies instead of checks
                 Key: THRIFT-3066
                 URL: https://issues.apache.org/jira/browse/THRIFT-3066
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
    Affects Versions: 0.9.2
            Reporter: James E. King, III
            Priority: Minor


cppcheck-1.68 found an assertion that is assigning a value:
{noformat}  // If this is the end of the top-level write, we should have just popped
  // the TypeSpec passed to the constructor.
  if (ts_stack_.empty()) {
    assert(old_tts = type_spec_);
    return;
  }
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)