[GitHub] [incubator-iotdb] wshao08 commented on a change in pull request #1221: [IOTDB-653]Separate LAST cache from MTree

[GitBox <gi...@apache.org>]

wshao08 commented on a change in pull request #1221:
URL: https://github.com/apache/incubator-iotdb/pull/1221#discussion_r429819878



##########
File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBGroupByFillIT.java
##########
@@ -316,6 +317,7 @@ public void previousUntilLastTest1() {
     try (Connection connection = DriverManager.
             getConnection("jdbc:iotdb://127.0.0.1:6667/", "root", "root");
          Statement statement = connection.createStatement()) {
+      LastCacheManager.getInstance().clear();

Review comment:
       Fixed

##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/LastQueryExecutor.java
##########
@@ -179,7 +177,8 @@ public static TimeValuePair calculateLastPairForOneSeries(
     }
 
     // Update cached last value with low priority
-    node.updateCachedLast(resultPair, false, Long.MIN_VALUE);
+    LastCacheManager.getInstance().put(seriesPath.getFullPath(), resultPair, false);
+    //node.updateCachedLast(resultPair, false, Long.MIN_VALUE);

Review comment:
       Fixed

##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/LastQueryExecutor.java
##########
@@ -22,7 +22,10 @@
 
 import static org.apache.iotdb.db.conf.IoTDBConstant.COLUMN_VALUE;
 import static org.apache.iotdb.db.conf.IoTDBConstant.COLUMN_TIMESERIES;
+
+import java.sql.Time;

Review comment:
       Removed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org