You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2017/08/01 22:03:55 UTC

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page 

srisaikumarravipati@inspur.com has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7555

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................

KUDU-2060. Show primary keys in the master's table web UI page

Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
---
M src/kudu/server/webui_util.cc
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/7555/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7555/1/src/kudu/server/webui_util.cc
File src/kudu/server/webui_util.cc:

Line 46: 			Substitute("<u>$0</u>", col.name()) :
- hard tabs are not allowed


Line 52:     string write_default = "-";		
trailing whitespace


Line 61:                           EscapeForHtmlToString(col_name),
I suspect that you didn't try out this change, because here you are using HTML escaping on a value that you've put HTML inside up above, which means you'll see a literal <u>...</u> in the web UI.

For changes like this if you can't add a unit test please test manually before posting for review


-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7555/2/src/kudu/server/webui_util.cc
File src/kudu/server/webui_util.cc:

Line 62:                           EscapeForHtmlToString(col_name),
again you are double escaping. please test your changes before submitting for review.


-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7555

to look at the new patch set (#4).

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................

KUDU-2060. Show primary keys in the master's table web UI page

Bug fixes-3

Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
---
M src/kudu/server/webui_util.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/7555/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7555/4//COMMIT_MSG
Commit Message:

Line 9: Bug fixes-3
this shouldn't be in the commit message. it becomes a permanent part of the project history, and this has no value going forward


-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: srisaikumarravipati@inspur.com
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
srisaikumarravipati@inspur.com has posted comments on this change.

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................


Patch Set 4:

The issues should be resolved now - Sri Sai Kumar

-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: srisaikumarravipati@inspur.com
Gerrit-HasComments: No

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7555/1/src/kudu/server/webui_util.cc
File src/kudu/server/webui_util.cc:

Line 45:     const col_name = schema.is_key_column(col.name()) ?
also your code doesn't compile.


-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2060: Show primary keys in the master's table web UI page

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7555

to look at the new patch set (#6).

Change subject: KUDU-2060: Show primary keys in the master's table web UI page
......................................................................

KUDU-2060: Show primary keys in the master's table web UI page

Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
---
M src/kudu/server/webui_util.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/7555/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: srisaikumarravipati@inspur.com

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7555

to look at the new patch set (#3).

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................

KUDU-2060. Show primary keys in the master's table web UI page

Bug fixes-2

Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
---
M src/kudu/server/webui_util.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/7555/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7555

to look at the new patch set (#5).

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................

KUDU-2060. Show primary keys in the master's table web UI page

Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
---
M src/kudu/server/webui_util.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/7555/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: srisaikumarravipati@inspur.com

[kudu-CR] KUDU-2060. Show primary keys in the master's table web UI page

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7555

to look at the new patch set (#2).

Change subject: KUDU-2060. Show primary keys in the master's table web UI page
......................................................................

KUDU-2060. Show primary keys in the master's table web UI page

Bug fixes

Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
---
M src/kudu/server/webui_util.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/7555/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-2060: Show primary keys in the master's table web UI page

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
srisaikumarravipati@inspur.com has abandoned this change.

Change subject: KUDU-2060: Show primary keys in the master's table web UI page
......................................................................


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/7555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I003d1016ff6e513637b14b4d3f7cf8fed8501a25
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarravipati@inspur.com
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: srisaikumarravipati@inspur.com