You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by 徐靖峰 <ki...@foxmail.com> on 2018/08/23 18:04:44 UTC
TagRouter additional description
Hi everyone
Forgive me for not being able to use mail list skillfully，some picture and link were lost in last email,
more details about the issue can refer https://github.com/apache/incubator-dubbo/issues/2341
Re:Re:Re: TagRouter additional description
Posted by 秦金卫 <ki...@163.com>.
@Ian @ Kirito
I update default value to true in https://github.com/apache/incubator-dubbo/pull/2343, plz review.
At 2018-08-27 23:08:25, "秦金卫" <ki...@163.com> wrote:
>TRUE means strictly matching
>FALSE means the most matching
>
>
>To me, if users can trun it on/off, default value is not a big issue.
>
>At 2018-08-27 13:14:22, "Ian Luo" <ia...@gmail.com> wrote:
>>I quote Kirito Moe's questions here for discussion convenience:
>>
>>Need more discussion
>>
>> 1. If a tag request can not find any application of the same tag，should
>> it use other application of different tag (NOTICE : different tag is not
>> the default application with grey block)
>> 2. If a normal request can not find normal application，should it use any
>> tag application?(in my opinion，normal request should not reach the tag
>> application，also the current version).
>> 3. A forceTag flag can be considered to decided the behavior of
>> downgrade. forceTag=true means all tag requests must strictly match the
>> application's tag；forceTag=false means tag requests will prefer the
>> application of the same tag，if there is no corresponding application，
>> downgrade to other application，ignore the tag.
>> 4. On the basis of 3. what is default value of foreTag TRUE or FALSE.
>>
>>
>>Here below are my answers:
>>
>>For points 1 and 2, I think we should not allow the traffic be routed to
>>the server instance on which a different tag is specified since it usually
>>means different service implementation, but at the same time, I believe it
>>is reasonable to route the traffic to the instance with has no tag
>>specified at all, because no-tag-service usually means main stream service
>>which is public to all clients. In summary, I believe the behavior should
>>looks like this:
>>
>>1. branch request -> main stream service (v)
>>2. branch1 request -> branch2 service (x)
>>3. branch1 request -> branch1 service (v)
>>
>>For the point 3, it looks like Kirito wants to add one flag in order to
>>customize the behavior when needed, which I think it's a good thoughts, but
>>the default value should reflect to the default behavior, as I describe
>>above, which is TRUE.
>>
>>This is my two cents.
>>
>>Regards,
>>-Ian.
>>
>>
>>On Fri, Aug 24, 2018 at 2:12 AM 徐靖峰 <ki...@foxmail.com> wrote:
>>
>>> Hi everyone
>>>
>>>
>>> Forgive me for not being able to use mail list skillfully，some picture and
>>> link were lost in last email,
>>>
>>>
>>> more details about the issue can refer
>>> https://github.com/apache/incubator-dubbo/issues/2341
Re:Re: TagRouter additional description
Posted by 秦金卫 <ki...@163.com>.
TRUE means strictly matching
FALSE means the most matching
To me, if users can trun it on/off, default value is not a big issue.
At 2018-08-27 13:14:22, "Ian Luo" <ia...@gmail.com> wrote:
>I quote Kirito Moe's questions here for discussion convenience:
>
>Need more discussion
>
> 1. If a tag request can not find any application of the same tag，should
> it use other application of different tag (NOTICE : different tag is not
> the default application with grey block)
> 2. If a normal request can not find normal application，should it use any
> tag application?(in my opinion，normal request should not reach the tag
> application，also the current version).
> 3. A forceTag flag can be considered to decided the behavior of
> downgrade. forceTag=true means all tag requests must strictly match the
> application's tag；forceTag=false means tag requests will prefer the
> application of the same tag，if there is no corresponding application，
> downgrade to other application，ignore the tag.
> 4. On the basis of 3. what is default value of foreTag TRUE or FALSE.
>
>
>Here below are my answers:
>
>For points 1 and 2, I think we should not allow the traffic be routed to
>the server instance on which a different tag is specified since it usually
>means different service implementation, but at the same time, I believe it
>is reasonable to route the traffic to the instance with has no tag
>specified at all, because no-tag-service usually means main stream service
>which is public to all clients. In summary, I believe the behavior should
>looks like this:
>
>1. branch request -> main stream service (v)
>2. branch1 request -> branch2 service (x)
>3. branch1 request -> branch1 service (v)
>
>For the point 3, it looks like Kirito wants to add one flag in order to
>customize the behavior when needed, which I think it's a good thoughts, but
>the default value should reflect to the default behavior, as I describe
>above, which is TRUE.
>
>This is my two cents.
>
>Regards,
>-Ian.
>
>
>On Fri, Aug 24, 2018 at 2:12 AM 徐靖峰 <ki...@foxmail.com> wrote:
>
>> Hi everyone
>>
>>
>> Forgive me for not being able to use mail list skillfully，some picture and
>> link were lost in last email,
>>
>>
>> more details about the issue can refer
>> https://github.com/apache/incubator-dubbo/issues/2341
Re: TagRouter additional description
Posted by Ian Luo <ia...@gmail.com>.
I quote Kirito Moe's questions here for discussion convenience:
Need more discussion
1. If a tag request can not find any application of the same tag，should
it use other application of different tag (NOTICE : different tag is not
the default application with grey block)
2. If a normal request can not find normal application，should it use any
tag application?(in my opinion，normal request should not reach the tag
application，also the current version).
3. A forceTag flag can be considered to decided the behavior of
downgrade. forceTag=true means all tag requests must strictly match the
application's tag；forceTag=false means tag requests will prefer the
application of the same tag，if there is no corresponding application，
downgrade to other application，ignore the tag.
4. On the basis of 3. what is default value of foreTag TRUE or FALSE.
Here below are my answers:
For points 1 and 2, I think we should not allow the traffic be routed to
the server instance on which a different tag is specified since it usually
means different service implementation, but at the same time, I believe it
is reasonable to route the traffic to the instance with has no tag
specified at all, because no-tag-service usually means main stream service
which is public to all clients. In summary, I believe the behavior should
looks like this:
1. branch request -> main stream service (v)
2. branch1 request -> branch2 service (x)
3. branch1 request -> branch1 service (v)
For the point 3, it looks like Kirito wants to add one flag in order to
customize the behavior when needed, which I think it's a good thoughts, but
the default value should reflect to the default behavior, as I describe
above, which is TRUE.
This is my two cents.
Regards,
-Ian.
On Fri, Aug 24, 2018 at 2:12 AM 徐靖峰 <ki...@foxmail.com> wrote:
> Hi everyone
>
>
> Forgive me for not being able to use mail list skillfully，some picture and
> link were lost in last email,
>
>
> more details about the issue can refer
> https://github.com/apache/incubator-dubbo/issues/2341