You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Sam Ruby <ru...@apache.org> on 2002/12/27 13:16:52 UTC

[PATCH] Eliminate circular dependency between altrmi and phoenix

Altrmi now has code for blocks, which introduces dependencies on 
cornerstone and phoenix.  Cornerstone has code which depends on altrmi, 
phoenix indirectly has a similar compilation dependency.

What I would like to be able to do is to compile the "core" of altrmi 
first - i.e., everything except the blocks.  If that is successful, then 
compilation can proceed to phoenix and cornerstone.  If each of these is 
successful, then an attempt will be made to go back and compile the 
altrmi blocks with the latest phoenix and cornerstone class definitions.

Patch below

Index: build.xml
===================================================================
RCS file: /home/cvs/jakarta-avalon-excalibur/altrmi/build.xml,v
retrieving revision 1.55
diff -u -r1.55 build.xml
--- build.xml   27 Dec 2002 00:07:27 -0000      1.55
+++ build.xml   27 Dec 2002 12:04:28 -0000
@@ -9,6 +9,7 @@
      <property file="${basedir}/default.properties"/>
      <property file="${user.home}/.ant.properties"/>
      <property file="default.properties"/>
+    <available property="block.present" 
classname="org.apache.avalon.phoenix.BlockEvent"/>


      <property name ="jetty.rel"    value="4.2.2"/>
@@ -105,6 +106,7 @@
              target="1.2">
              <classpath refid="project.class.path" />
              <include name="**/*.java"/>
+            <exclude name="org/apache/excalibur/altrmi/blocks/**" 
unless="block.present"/>
              <exclude 
name="org/apache/excalibur/altrmi/server/impl/http/*.java" 
unless="jetty.present"/>
          </javac>

@@ -166,7 +168,7 @@

      </target>

-  <target name="metagenerate" description="Generates the XML descriptors">
+  <target name="metagenerate" if="block.present" description="Generates 
the XML descriptors">

      <taskdef name="generatemeta" 
classname="org.apache.avalon.phoenix.tools.metagenerate.MetaGenerateTask">
        <classpath refid="project.class.path" />

- Sam Ruby




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Eliminate circular dependency between altrmi and phoenix

Posted by Paul Hammant <pa...@yahoo.com>.
Sam,

> > Thanks, but Phoenix and Cornerstone no longer depend on AltRMI (or never did).  It must be
> gump
> > entries that are wrong.  I deleted one dep from the gump for cornerstone, but did not add any
> for
> > the gump for altrmi (for two reasons: grok and locn of that gump file).
> 
> Does excalibur-component depend on altrmi?

The core package does not. One of the examples depends on 'instrument' which does use AltRMI.
Though AltRMI is used in build/properies files, I can't see it being used in Java*

> Does excalibur-monitor depend on component?
> Does phoenix depend on monitor?

*Let us still go ahead with the split of dependancies though.

> As for both grok and locn, I can help with both.
> 
> --- GROK ---
> 
> In the following file:
> 
>
http://cvs.apache.org/viewcvs/jakarta-alexandria/proposal/gump/project/jakarta-avalon-cornerstone.xml?rev=1.52&content-type=text/vnd.viewcvs-markup

I will learn the above, and look forward to the prescribed public gump moment.

- Paul

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Eliminate circular dependency between altrmi and phoenix

Posted by Sam Ruby <ru...@apache.org>.
Paul Hammant wrote:
> 
> Thanks, but Phoenix and Cornerstone no longer depend on AltRMI (or never did).  It must be gump
> entries that are wrong.  I deleted one dep from the gump for cornerstone, but did not add any for
> the gump for altrmi (for two reasons: grok and locn of that gump file).

Does excalibur-component depend on altrmi?
Does excalibur-monitor depend on component?
Does phoenix depend on monitor?

As for both grok and locn, I can help with both.

--- GROK ---

In the following file:

http://cvs.apache.org/viewcvs/jakarta-alexandria/proposal/gump/project/jakarta-avalon-cornerstone.xml?rev=1.52&content-type=text/vnd.viewcvs-markup

there is a line that says

<option project="excalibur-altrmi" inherit="runtime"/>

the documentation for that element can be found at:

http://jakarta.apache.org/gump/project.html#option

--- LOCN ---

Past history:

Any committer who has demonstrated an ability to build the "gen" target 
of gump's build.xml (elapsed time is typically less than one minute, the 
only dependencies are ant, xerces, and xalan), and has expressed an 
interest in maintaining one or more descriptors, has been immediately 
voted in as a committer to Alexandria.

If the project definition in jakarta-avalon-cornerstone's cvs will be 
maintained, then gump can pick it up from there.  My experience has been 
otherwise.  Four months ago Peter Donald tried moving the gump 
descriptors to the various Avalon cvs's.  Other than PeterD himself, I 
saw little interest in the Avalon community for maintaining these 
descriptions.  Therefore, the only affect of this was to make it so that 
those who were actively interested in maintaining this were unable to do 
so.  I was pleased when Peter moved these files back.

Current plans:

The current plans is to create a cvs where any Apache committer can make 
a change.  This should be done this week.  The reason is simple: 
apparently the above two policies were not liberal enough.  Hopefully 
this new approach will eliminate any excuses.

- Sam Ruby




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Eliminate circular dependency between altrmi and phoenix

Posted by Paul Hammant <pa...@yahoo.com>.
Sam,

Thanks, but Phoenix and Cornerstone no longer depend on AltRMI (or never did).  It must be gump
entries that are wrong.  I deleted one dep from the gump for cornerstone, but did not add any for
the gump for altrmi (for two reasons: grok and locn of that gump file).

Your suggestion is not so bad though, so I may well apply it.  Especially as the blocks will
require integration unit testing under punit control.

- Paul

 --- Sam Ruby <ru...@apache.org> wrote: > Altrmi now has code for blocks, which introduces
dependencies on 
> cornerstone and phoenix.  Cornerstone has code which depends on altrmi, 
> phoenix indirectly has a similar compilation dependency.
> 
> What I would like to be able to do is to compile the "core" of altrmi 
> first - i.e., everything except the blocks.  If that is successful, then 
> compilation can proceed to phoenix and cornerstone.  If each of these is 
> successful, then an attempt will be made to go back and compile the 
> altrmi blocks with the latest phoenix and cornerstone class definitions.
> 
> Patch below
> 
> Index: build.xml
> ===================================================================
> RCS file: /home/cvs/jakarta-avalon-excalibur/altrmi/build.xml,v
> retrieving revision 1.55
> diff -u -r1.55 build.xml
> --- build.xml   27 Dec 2002 00:07:27 -0000      1.55
> +++ build.xml   27 Dec 2002 12:04:28 -0000
> @@ -9,6 +9,7 @@
>       <property file="${basedir}/default.properties"/>
>       <property file="${user.home}/.ant.properties"/>
>       <property file="default.properties"/>
> +    <available property="block.present" 
> classname="org.apache.avalon.phoenix.BlockEvent"/>
> 
> 
>       <property name ="jetty.rel"    value="4.2.2"/>
> @@ -105,6 +106,7 @@
>               target="1.2">
>               <classpath refid="project.class.path" />
>               <include name="**/*.java"/>
> +            <exclude name="org/apache/excalibur/altrmi/blocks/**" 
> unless="block.present"/>
>               <exclude 
> name="org/apache/excalibur/altrmi/server/impl/http/*.java" 
> unless="jetty.present"/>
>           </javac>
> 
> @@ -166,7 +168,7 @@
> 
>       </target>
> 
> -  <target name="metagenerate" description="Generates the XML descriptors">
> +  <target name="metagenerate" if="block.present" description="Generates 
> the XML descriptors">
> 
>       <taskdef name="generatemeta" 
> classname="org.apache.avalon.phoenix.tools.metagenerate.MetaGenerateTask">
>         <classpath refid="project.class.path" />
> 
> - Sam Ruby
> 
> 
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>  

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>