You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Shashank Tandon <st...@expedia.com> on 2015/10/26 08:01:06 UTC
Review Request 39640: Review for issue SQOOP-2627:Incremental imports
fail in Sqoop when run using Teradata JDBC driver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39640/
-----------------------------------------------------------
Review request for Sqoop and Venkat Ranganathan.
Repository: sqoop-trunk
Description
-------
When sqoop incremental import is run over Teradata DB,
sqoop import --driver com.teradata.jdbc.TeraDriver --connect jdbc:teradata://10.126.62.46/DATABASE=SampleDb,TMODE=ANSI,LOGMECH=LDAP --username abc -P --table test1 --incremental lastmodified --check-column DAT --last-value '2014-10-22 07:00:00' --target-dir /user/$USER/hive_data_dynapart/test1dir
then the following error occurs:
15/09/24 03:57:10 ERROR manager.SqlManager: SQL exception accessing current timestamp: com.teradata.jdbc.jdbc_4.util.JDBCException: [Teradata Database] [TeraJDBC 14.10.00.26] [Error 3706] [SQLState 42000] Syntax error: expected something between '(' and ')'.
com.teradata.jdbc.jdbc_4.util.JDBCException: [Teradata Database] [TeraJDBC 14.10.00.26] [Error 3706] [SQLState 42000] Syntax error: expected something between '(' and ')'.
at com.teradata.jdbc.jdbc_4.util.ErrorFactory.makeDatabaseSQLException(ErrorFactory.java:307)
at com.teradata.jdbc.jdbc_4.statemachine.ReceiveInitSubState.action(ReceiveInitSubState.java:109)
at com.teradata.jdbc.jdbc_4.statemachine.StatementReceiveState.subStateMachine(StatementReceiveState.java:314)
at com.teradata.jdbc.jdbc_4.statemachine.StatementReceiveState.action(StatementReceiveState.java:202)
at com.teradata.jdbc.jdbc_4.statemachine.StatementController.runBody(StatementController.java:123)
at com.teradata.jdbc.jdbc_4.statemachine.StatementController.run(StatementController.java:114)
at com.teradata.jdbc.jdbc_4.TDStatement.executeStatement(TDStatement.java:384)
at com.teradata.jdbc.jdbc_4.TDStatement.executeStatement(TDStatement.java:326)
at com.teradata.jdbc.jdbc_4.TDStatement.doNonPrepExecuteQuery(TDStatement.java:314)
at com.teradata.jdbc.jdbc_4.TDStatement.executeQuery(TDStatement.java:1091)
at org.apache.sqoop.manager.SqlManager.getCurrentDbTimestamp(SqlManager.java:987)
at org.apache.sqoop.tool.ImportTool.initIncrementalConstraints(ImportTool.java:328)
at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:488)
at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:605)
at org.apache.sqoop.Sqoop.run(Sqoop.java:143)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:179)
at org.apache.sqoop.Sqoop.runTool(Sqoop.java:218)
at org.apache.sqoop.Sqoop.runTool(Sqoop.java:227)
at org.apache.sqoop.Sqoop.main(Sqoop.java:236)
15/09/24 03:57:10 ERROR tool.ImportTool: Encountered IOException running import job: java.io.IOException: Could not get current time from database
at org.apache.sqoop.tool.ImportTool.initIncrementalConstraints(ImportTool.java:330)
at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:488)
at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:605)
at org.apache.sqoop.Sqoop.run(Sqoop.java:143)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:179)
at org.apache.sqoop.Sqoop.runTool(Sqoop.java:218)
at org.apache.sqoop.Sqoop.runTool(Sqoop.java:227)
at org.apache.sqoop.Sqoop.main(Sqoop.java:236)
Diffs
-----
src/docs/user/connectors.txt c5ce4d6
src/java/com/cloudera/sqoop/manager/TeradataJdbcManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/TeradataJdbcManager.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/db/TeradataDataDrivenDBInputFormat.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/db/TeradataDataDrivenDBRecordReader.java PRE-CREATION
src/test/com/cloudera/sqoop/manager/TestImportInTeradataJdbcManager.java PRE-CREATION
Diff: https://reviews.apache.org/r/39640/diff/
Testing
-------
YES
Thanks,
Shashank Tandon
Re: Review Request 39640: Review for issue SQOOP-2627:Incremental
imports fail in Sqoop when run using Teradata JDBC driver
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39640/#review104136
-----------------------------------------------------------
src/java/com/cloudera/sqoop/manager/TeradataJdbcManager.java (line 25)
<https://reviews.apache.org/r/39640/#comment162394>
For newer changes we are not updating the com.cloudera package.
src/java/org/apache/sqoop/manager/TeradataJdbcManager.java (line 46)
<https://reviews.apache.org/r/39640/#comment162395>
I see multiple versions of these files in another patch. Can we get the TeradataJDBC manager into a single coordinate JIRA with sub JIRA tickets?
src/test/com/cloudera/sqoop/manager/TestImportInTeradataJdbcManager.java (line 57)
<https://reviews.apache.org/r/39640/#comment162396>
Test prefixed for test suites should not depend on external resources. Can you rename it
- Venkat Ranganathan
On Oct. 26, 2015, 12:01 a.m., Shashank Tandon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39640/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 12:01 a.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> When sqoop incremental import is run over Teradata DB,
> sqoop import --driver com.teradata.jdbc.TeraDriver --connect jdbc:teradata://10.126.62.46/DATABASE=SampleDb,TMODE=ANSI,LOGMECH=LDAP --username abc -P --table test1 --incremental lastmodified --check-column DAT --last-value '2014-10-22 07:00:00' --target-dir /user/$USER/hive_data_dynapart/test1dir
> then the following error occurs:
> 15/09/24 03:57:10 ERROR manager.SqlManager: SQL exception accessing current timestamp: com.teradata.jdbc.jdbc_4.util.JDBCException: [Teradata Database] [TeraJDBC 14.10.00.26] [Error 3706] [SQLState 42000] Syntax error: expected something between '(' and ')'.
> com.teradata.jdbc.jdbc_4.util.JDBCException: [Teradata Database] [TeraJDBC 14.10.00.26] [Error 3706] [SQLState 42000] Syntax error: expected something between '(' and ')'.
> at com.teradata.jdbc.jdbc_4.util.ErrorFactory.makeDatabaseSQLException(ErrorFactory.java:307)
> at com.teradata.jdbc.jdbc_4.statemachine.ReceiveInitSubState.action(ReceiveInitSubState.java:109)
> at com.teradata.jdbc.jdbc_4.statemachine.StatementReceiveState.subStateMachine(StatementReceiveState.java:314)
> at com.teradata.jdbc.jdbc_4.statemachine.StatementReceiveState.action(StatementReceiveState.java:202)
> at com.teradata.jdbc.jdbc_4.statemachine.StatementController.runBody(StatementController.java:123)
> at com.teradata.jdbc.jdbc_4.statemachine.StatementController.run(StatementController.java:114)
> at com.teradata.jdbc.jdbc_4.TDStatement.executeStatement(TDStatement.java:384)
> at com.teradata.jdbc.jdbc_4.TDStatement.executeStatement(TDStatement.java:326)
> at com.teradata.jdbc.jdbc_4.TDStatement.doNonPrepExecuteQuery(TDStatement.java:314)
> at com.teradata.jdbc.jdbc_4.TDStatement.executeQuery(TDStatement.java:1091)
> at org.apache.sqoop.manager.SqlManager.getCurrentDbTimestamp(SqlManager.java:987)
> at org.apache.sqoop.tool.ImportTool.initIncrementalConstraints(ImportTool.java:328)
> at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:488)
> at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:605)
> at org.apache.sqoop.Sqoop.run(Sqoop.java:143)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:179)
> at org.apache.sqoop.Sqoop.runTool(Sqoop.java:218)
> at org.apache.sqoop.Sqoop.runTool(Sqoop.java:227)
> at org.apache.sqoop.Sqoop.main(Sqoop.java:236)
> 15/09/24 03:57:10 ERROR tool.ImportTool: Encountered IOException running import job: java.io.IOException: Could not get current time from database
> at org.apache.sqoop.tool.ImportTool.initIncrementalConstraints(ImportTool.java:330)
> at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:488)
> at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:605)
> at org.apache.sqoop.Sqoop.run(Sqoop.java:143)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:179)
> at org.apache.sqoop.Sqoop.runTool(Sqoop.java:218)
> at org.apache.sqoop.Sqoop.runTool(Sqoop.java:227)
> at org.apache.sqoop.Sqoop.main(Sqoop.java:236)
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt c5ce4d6
> src/java/com/cloudera/sqoop/manager/TeradataJdbcManager.java PRE-CREATION
> src/java/org/apache/sqoop/manager/TeradataJdbcManager.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/db/TeradataDataDrivenDBInputFormat.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/db/TeradataDataDrivenDBRecordReader.java PRE-CREATION
> src/test/com/cloudera/sqoop/manager/TestImportInTeradataJdbcManager.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39640/diff/
>
>
> Testing
> -------
>
> YES
>
>
> Thanks,
>
> Shashank Tandon
>
>