You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Bruno MAHE <bm...@apache.org> on 2013/11/22 10:50:35 UTC
Review Request 15785: FLUME-2248 Redis sink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15785/
-----------------------------------------------------------

Review request for Flume.


Bugs: FLUME-2248
    https://issues.apache.org/jira/browse/FLUME-2248


Repository: flume-git


Description
-------

Here is a new sink for Redis.
It includes unit tests (87.4% coverage of the code by the unit tests) and has been tested on some real instances of Apache Flume and Redis.
It is also able to serialize to Logstash format through jackson or to any format since the serializer can be provided through Apache Flume configuration.

There are a few things I would like to improve on the current patch, but I would rather have this reviewed first before the patch gets really big.


Diffs
-----

  flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 8ce372d 
  flume-ng-dist/pom.xml 2d0ee47 
  flume-ng-sinks/flume-ng-redis-sink/pom.xml PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/JedisPoolFactory.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/JedisPoolFactoryImpl.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/RedisSink.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/RedisSinkConfigurationConstant.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/serializer/LogstashEvent.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/serializer/LogstashSerializer.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/serializer/PlainSerializer.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/serializer/RedisSerializerException.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/main/java/org/apache/flume/sink/redis/serializer/Serializer.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/test/java/org/apache/flume/sink/redis/MockJedisPoolFactory.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/test/java/org/apache/flume/sink/redis/TestRedisSink.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/test/java/org/apache/flume/sink/redis/TestRedisSinkCreation.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/test/java/org/apache/flume/sink/redis/TestRedisSinkExceptions.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/test/java/org/apache/flume/sink/redis/TestRedisSinkSerializer.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/test/java/org/apache/flume/sink/redis/serializer/TestLogstashSerializer.java PRE-CREATION 
  flume-ng-sinks/flume-ng-redis-sink/src/test/java/org/apache/flume/sink/redis/serializer/TestPlainSerializer.java PRE-CREATION 
  flume-ng-sinks/pom.xml d03576b 
  pom.xml 267925f 

Diff: https://reviews.apache.org/r/15785/diff/


Testing
-------

It includes unit tests (87.4% coverage of the code by the unit tests) and has been tested on some real instances of Apache Flume and Redis.


Thanks,

Bruno MAHE