You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/12/23 20:31:01 UTC
[GitHub] [cordova-windows] brodybits opened a new pull request #371: [MAJOR
...] drop 8.1 support
brodybits opened a new pull request #371: [MAJOR ...] drop 8.1 support
URL: https://github.com/apache/cordova-windows/pull/371
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
see #361
### Description
<!-- Describe your changes in detail -->
Drop support for Windows 8.1 & Windows Phone 8.1 (WP 8.1)
based on some of the earlier changes in PR #264, with a some additional changes & adaptations
Note that the primary purpose is to end support for the obsolete Windows 8.1 & WP 8.1 operating systems as soon as possible. I would like to do a more thorough cleanup in a separate followup PR.
- remove support & handling of Windows 8.1 & WP 8.1 projects
- remove Windows 8.1 & WP 8.1 jsproj (build projects) from the template
- update unit tests to use build tools version 15.0
- skip unit tests & Jasmine end-to-end tests on Windows 8.1 & WP 8.1
- update AppVeyor to test on Node.js 10 & 12
- drop support for use with Visual Studio 2015
- drop support for super-old Visual Studio 2013
- remove old VS 2013 project from template
- test cleanup: remove CordovaApp.vs2012.sln fixture not needed
- update README.md
- other minor updates & fixes
- add some FUTURE TBD comments
- add some TODO comments
Some TODO items:
- [ ] update the package version first since this needs to be part of a new major release
- [ ] drop support for Node.js <10
- [ ] remove old appxmanifest artifacts for Windows 8.1 & WP 8.1 from template
- [ ] remove old, obsolete project & appxmanifest artifacts from the dummy unit test fixture
- [ ] check for more changes in PR #264 that should be applied to this PR
- [ ] update the documentation
- [ ] followup cleanup PR
- [ ] check for any changes in PR #264 that should be included in the followup cleanup PR
### Testing
<!-- Please describe in detail how you tested your changes. -->
- did `npm run test-unit` on my local machine
- ensured green build on AppVeyor (and on Travis CI)
- tried adding to cordova-sqlite-storage `spec` test project from a branch with these changes and verified that it succeeds on Windows 10 desktop and mobile
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- ~~I added automated test coverage as appropriate for this change~~
- ~~Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)~~
- ~~If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))~~
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-windows] codecov-io edited a comment on issue #371: [MAJOR
...] drop 8.1 support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #371: [MAJOR ...] drop 8.1 support
URL: https://github.com/apache/cordova-windows/pull/371#issuecomment-568836614
# [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=h1) Report
> Merging [#371](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-windows/commit/cba6a2bc6363acec23d05968e42044f989fa8d5d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `25%`.
[](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 73.65% 73.64% -0.01%
==========================================
Files 17 17
Lines 2118 2106 -12
==========================================
- Hits 1560 1551 -9
+ Misses 558 555 -3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [template/cordova/lib/AppxManifest.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvQXBweE1hbmlmZXN0Lmpz) | `80% <ø> (ø)` | :arrow_up: |
| [template/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvdXRpbHMuanM=) | `36% <0%> (ø)` | :arrow_up: |
| [bin/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-YmluL2xpYi9jaGVja19yZXFzLmpz) | `31.61% <0%> (-0.42%)` | :arrow_down: |
| [template/cordova/lib/MSBuildTools.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvTVNCdWlsZFRvb2xzLmpz) | `63.01% <100%> (+0.17%)` | :arrow_up: |
| [template/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvYnVpbGQuanM=) | `73.79% <33.33%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=footer). Last update [cba6a2b...4fa4017](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-windows] codecov-io commented on issue #371: [MAJOR ...]
drop 8.1 support
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #371: [MAJOR ...] drop 8.1 support
URL: https://github.com/apache/cordova-windows/pull/371#issuecomment-568836614
# [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d348c83`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #371 +/- ##
=========================================
Coverage ? 73.64%
=========================================
Files ? 17
Lines ? 2106
Branches ? 0
=========================================
Hits ? 1551
Misses ? 555
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [template/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvYnVpbGQuanM=) | `73.79% <ø> (ø)` | |
| [template/cordova/lib/MSBuildTools.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvTVNCdWlsZFRvb2xzLmpz) | `63.01% <ø> (ø)` | |
| [template/cordova/lib/AppxManifest.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvQXBweE1hbmlmZXN0Lmpz) | `80% <ø> (ø)` | |
| [template/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvdXRpbHMuanM=) | `36% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=footer). Last update [d348c83...9db30c7](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-windows] codecov-io edited a comment on issue #371: [MAJOR
...] drop 8.1 support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #371: [MAJOR ...] drop 8.1 support
URL: https://github.com/apache/cordova-windows/pull/371#issuecomment-568836614
# [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=h1) Report
> Merging [#371](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-windows/commit/cba6a2bc6363acec23d05968e42044f989fa8d5d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `25%`.
[](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 73.65% 73.64% -0.01%
==========================================
Files 17 17
Lines 2118 2106 -12
==========================================
- Hits 1560 1551 -9
+ Misses 558 555 -3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [template/cordova/lib/AppxManifest.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvQXBweE1hbmlmZXN0Lmpz) | `80% <ø> (ø)` | :arrow_up: |
| [template/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvdXRpbHMuanM=) | `36% <0%> (ø)` | :arrow_up: |
| [bin/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-YmluL2xpYi9jaGVja19yZXFzLmpz) | `31.61% <0%> (-0.42%)` | :arrow_down: |
| [template/cordova/lib/MSBuildTools.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvTVNCdWlsZFRvb2xzLmpz) | `63.01% <100%> (+0.17%)` | :arrow_up: |
| [template/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-windows/pull/371/diff?src=pr&el=tree#diff-dGVtcGxhdGUvY29yZG92YS9saWIvYnVpbGQuanM=) | `73.79% <33.33%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=footer). Last update [cba6a2b...4fa4017](https://codecov.io/gh/apache/cordova-windows/pull/371?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org