You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2017/01/10 19:01:06 UTC

Re: Review Request 53712: Added `system` environment variables in ` execvpe.cpp`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53712/
-----------------------------------------------------------

(Updated Jan. 10, 2017, 7:01 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park.


Summary (updated)
-----------------

Added `system` environment variables in ` execvpe.cpp`.


Repository: mesos


Description (updated)
-------

Added `system` environment variables in ` execvpe.cpp`.


Diffs (updated)
-----

  src/slave/containerizer/mesos/launch.cpp e482ab8bdfc358f695b87cda72ca59fb64cd8c4d 

Diff: https://reviews.apache.org/r/53712/diff/


Testing
-------


Thanks,

Daniel Pravat


Re: Review Request 53712: Added `system` environment variables in ` execvpe.cpp`.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53712/#review161154
-----------------------------------------------------------



Looks like this is a diff-of-a-diff.  I'd expect the actual diff to look like revisions 2 and 3 combined.

- Joseph Wu


On Jan. 10, 2017, 11:01 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53712/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2017, 11:01 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `system` environment variables in ` execvpe.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp e482ab8bdfc358f695b87cda72ca59fb64cd8c4d 
> 
> Diff: https://reviews.apache.org/r/53712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>