You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/08/25 15:10:56 UTC
[kudu-CR] [docker] Support building and pushing multi-arch images
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16361
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
[docker] Support building and pushing multi-arch images
This change introduces support for building and pushing ARM
and multi-arch Docker images.
Note that building an image for a different architecture than
your machine is painfully slow due to emulation. Improvements
in emulation performance will likely come in the future.
Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
---
M docker/docker-build.py
1 file changed, 38 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/16361/1
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docker] Support building and pushing multi-arch images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16361 )
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
[docker] Support building and pushing multi-arch images
This change introduces support for building and pushing ARM
and multi-arch Docker images.
Note that building an image for a different architecture than
your machine is painfully slow due to emulation. Improvements
in emulation performance will likely come in the future.
Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Reviewed-on: http://gerrit.cloudera.org:8080/16361
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docker/docker-build.py
1 file changed, 38 insertions(+), 15 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Support building and pushing multi-arch images
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 )
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16361/1/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16361/1/docker/docker-build.py@316
PS1, Line 316: build_tags
Do we need to add per-platform tags? Or can we push images for multiple platforms with the same tags?
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Aug 2020 23:56:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Support building and pushing multi-arch images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 )
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
Patch Set 1:
I will push sample images to my docker hub repo today as well.
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Aug 2020 15:11:22 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Support building and pushing multi-arch images
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 )
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Aug 2020 22:30:35 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Support building and pushing multi-arch images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16361
to look at the new patch set (#2).
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
[docker] Support building and pushing multi-arch images
This change introduces support for building and pushing ARM
and multi-arch Docker images.
Note that building an image for a different architecture than
your machine is painfully slow due to emulation. Improvements
in emulation performance will likely come in the future.
Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
---
M docker/docker-build.py
1 file changed, 38 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/16361/2
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docker] Support building and pushing multi-arch images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 )
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16361/1/docker/docker-build.py
File docker/docker-build.py:
http://gerrit.cloudera.org:8080/#/c/16361/1/docker/docker-build.py@316
PS1, Line 316: build_tags
> Do we need to add per-platform tags? Or can we push images for multiple pla
The common practice is not to add a separate image tag for the platform, but instead to use build manifests to include all of the supported platforms under the same tag. Then the correct image for your platform is automatically pulled. Alternatively you can override and use emulation by specifying --platform in your run commands.
This is primarily what the buildx builder is doing for us. Building both images in parallel, generating the manifest, and pushing the images, manifests, and tags.
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 20:27:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Support building and pushing multi-arch images
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 )
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 21:05:18 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Support building and pushing multi-arch images
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16361 )
Change subject: [docker] Support building and pushing multi-arch images
......................................................................
Patch Set 1:
A sample of the pushed image can be seen here: https://hub.docker.com/layers/granthenke/kudu/latest/images/sha256-242e9d361dd1c43fa268cb58ee5cf358ea3802e83f64c7808e4e8f7e8a3a7f47?context=repo
--
To view, visit http://gerrit.cloudera.org:8080/16361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f64e4b9591927f160cdf886507cb740578e20b5
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 20:24:32 +0000
Gerrit-HasComments: No