You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/05 07:56:43 UTC
[GitHub] [yunikorn-k8shim] steinsgateted opened a new pull request, #446: [YUNIKORN-1270] Removal of unused queue field in Allocation
steinsgateted opened a new pull request, #446:
URL: https://github.com/apache/yunikorn-k8shim/pull/446
### What is this PR for?
remove the queue from the &si.Allocation
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1270
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #446: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #446:
URL: https://github.com/apache/yunikorn-k8shim/pull/446#issuecomment-1207567226
@manirajv06: the e2e preemption test seems to be flaky. I have seen it fail on different version of K8s for different PRs over the last week or so. Maybe the solution to detect the node etc is not good enough for all cases. Can you file a jira and followup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #446: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #446:
URL: https://github.com/apache/yunikorn-k8shim/pull/446#issuecomment-1208786960
Scheduler interface changes have been committed.
See the [docs](https://yunikorn.apache.org/docs/next/developer_guide/dependencies) on how to update the k8shim dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] manirajv06 commented on pull request #446: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on PR #446:
URL: https://github.com/apache/yunikorn-k8shim/pull/446#issuecomment-1208206662
Filed [YUNIKORN-1278](https://issues.apache.org/jira/browse/YUNIKORN-1278) to fix the flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #446: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #446:
URL: https://github.com/apache/yunikorn-k8shim/pull/446#issuecomment-1206165542
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#446](https://codecov.io/gh/apache/yunikorn-k8shim/pull/446?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8e2c88c) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/f676c05d3fbfb6e25e7fff2dc4766434a76456e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f676c05) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 67.34% 67.31% -0.04%
==========================================
Files 41 41
Lines 6744 6743 -1
==========================================
- Hits 4542 4539 -3
- Misses 2032 2034 +2
Partials 170 170
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/appmgmt/general/general.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwcG1nbXQvZ2VuZXJhbC9nZW5lcmFsLmdv) | `66.12% <ø> (-0.19%)` | :arrow_down: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/446/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #446: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #446: [YUNIKORN-1270] Removal of unused queue field in Allocation
URL: https://github.com/apache/yunikorn-k8shim/pull/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #446: [YUNIKORN-1270] Removal of unused queue field in Allocation
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #446:
URL: https://github.com/apache/yunikorn-k8shim/pull/446#issuecomment-1207566901
Change itself looks good. Before we commit we need to commit the scheduler-interface change and update the go.mod reference in the shim and get a build to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org