[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #11587: fix(transaction):fix transaction statement commit error while using shared thread pool and local transaction manager

[GitBox <gi...@apache.org>]

TeslaCN commented on a change in pull request #11587:
URL: https://github.com/apache/shardingsphere/pull/11587#discussion_r681615285



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/connection/BackendConnection.java
##########
@@ -81,7 +82,7 @@
     
     private final Collection<DatabaseCommunicationEngine> inUseDatabaseCommunicationEngines = Collections.newSetFromMap(new ConcurrentHashMap<>(64));
     
-    private final Collection<ConnectionPostProcessor> connectionPostProcessors = new LinkedList<>();
+    private final Collection<ConnectionPostProcessor> connectionPostProcessors = new CopyOnWriteArrayList<>();

Review comment:
       My understanding is if we defer the flush, client won't send next packet until the resources are closed and the processors will be operated by only one thread. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org