[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10274: feat: update timeout error UX

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #10274:
URL: https://github.com/apache/incubator-superset/pull/10274#discussion_r452501360



##########
File path: superset-frontend/src/components/ErrorMessage/constants.ts
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { t } from '@superset-ui/translation';
+
+const ROOT_ERROR_REFERENCE_URL =
+  'https://superset.apache.org/error_code_reference.html#';
+
+export const ERROR_DATASOURCE_TOO_LARGE = {
+  message: t('Error 1000 - The datasource is too large to query.'),
+  link: `${ROOT_ERROR_REFERENCE_URL}error-1000`,
+};

Review comment:
       +1 this. Error messages should be defined in API level. So that API user (that use json response without js rendered chart) should get the same message when some query went wrong.
   Front-end should handle how to render error by its code, not define what is this error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org