You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/23 09:35:17 UTC
[PR] test(frontend): cover the admin-execution and user-dataset templates [texera]
aglinxinyuan opened a new pull request, #7893:
URL: https://github.com/apache/texera/pull/7893
### What changes were proposed in this PR?
Two dashboard templates. 77 tests → 94.
Measured from `frontend/` with `ng test --coverage --coverage-reporters=lcovonly`, the same spec-file filter on both sides, `rm -rf coverage` between runs, and the "before" run taken from HEAD's specs rather than inherited from a report.
| Template | Before | After |
|---|---|---|
| `admin-execution.component.html` | 77/82 = 93.9% (5 missed) | **81/82 = 98.8%** (1 missed) |
| `user-dataset.component.html` | 32/37 = 86.5% (5 missed) | **37/37 = 100%**, branches **6/6** |
+9 fully-covered lines, +2 branch arms. Both "before" figures reproduce Codecov's published numbers exactly.
New tests cover the duration and end-time fallbacks, the filter and pagination wiring, and the dataset list's empty and populated states.
### Verification
29 mutations, **28 killed, 1 equivalent mutant.** Every mutant was run twice — once against the pre-review tree and once against the repaired tree — so the "now dies" claims are differences I observed rather than inferred.
The first draft reported `"survivors": []`. That was false: **17 distinct mutants survived at 87/87 on its own tree.** Its *numbers* were right — I reproduced 93.90%/5-missed, 86.49%/5-missed, +9 lines and +2 arms — but its closing claim that "the assessment was accurate on every number I checked" papered over the fact that the assertions behind those numbers did not constrain much.
Three of its test comments described separations the tests did not achieve:
- "The duration and end-time cells have independent fallbacks, so assert them separately" — each `ngIf` guard was in fact pinned in only one direction.
- An `EXCHANGE` of the pause and resume `[disabled]` predicates was framed as pinning the pair; it pins only pause-on-RUNNING and resume-on-PAUSED, not the converse.
- A comment claimed a template statement's assign-then-search ordering was observable; the test could not see it.
### This repair pass added zero coverage
The 7 new tests and 7 strengthenings buy **mutation strength, not lines** — the Codecov delta is identical before and after this pass. Said plainly so the diff size is not read as coverage.
### Deliberately not included, and honestly bounded
**This is not a claim that these templates are mutation-complete.** It is a claim about 29 specific mutants. Five wirings remain unpinned and are listed rather than hidden:
- `(nzQueryParams)` on line 43 and `(nzFilterChange)` on line 83 of `admin-execution.component.html` are both still `FNDA:0`. Deleting either would silently break every page click or filter change and nothing in the 53 tests would notice, because the pagination and filter suites call the handlers directly. Worth 0 Codecov lines either way.
- `(click)="setViewType('card')"` on `user-dataset.component.html:53` is still `FNDA:0` — the page starts in card view, so the existing toggle test only ever clicks the list button.
- `(refresh)="ngAfterViewInit()"` on line 100 is left unpinned **deliberately**: pinning it would cement a duplicate-subscription defect.
- Line 90's `(refresh)` has no `DA` record in the lcov at all, so it can never count toward the Codecov metric in either direction.
**`admin-execution.component.html:128` is the one remaining miss and it is dead markup**: `#endTimeNotAvailable` is declared twice, at lines 118 and 127, so lines 127-129 are unreachable. Re-verified from my own after-run lcov rather than inherited.
No production file is touched.
### Any related issues, documentation, discussions?
Closes #7892
### How was this PR tested?
```
npx ng test --watch=false --include="**/admin-execution.component.spec.ts" --include="**/user-dataset.component.spec.ts"
```
```
Test Files 2 passed (2)
Tests 94 passed (94)
```
`frontend/junit.xml` and `frontend/coverage/` are regenerated by every run and are not committed. `yarn format:ci` passes.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover the admin-execution and user-dataset templates [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7893:
URL: https://github.com/apache/texera/pull/7893#issuecomment-5385325561
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@mengw15`
You can notify them by mentioning `@mengw15` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover the admin-execution and user-dataset templates [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7893:
URL: https://github.com/apache/texera/pull/7893#issuecomment-5385352075
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7893?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.21%. Comparing base ([`65f1f66`](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`76d371b`](https://app.codecov.io/gh/apache/texera/commit/76d371baf71de145d801f72a7c1b2345861c7dd7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7893 +/- ##
============================================
+ Coverage 92.09% 92.21% +0.12%
Complexity 4533 4533
============================================
Files 1173 1173
Lines 47347 47347
Branches 5306 5306
============================================
+ Hits 43604 43661 +57
+ Misses 2105 2069 -36
+ Partials 1638 1617 -21
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.62% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.76% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.73% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.74% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `94.26% <ø> (+0.27%)` | :arrow_up: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.13% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.52% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [65f1f66](https://app.codecov.io/gh/apache/texera/commit/65f1f668acf38d83aa17991359477d3f2f44db3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7893?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): cover the admin-execution and user-dataset templates [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7893:
URL: https://github.com/apache/texera/pull/7893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org