You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/01 08:19:57 UTC

[GitHub] [geode-native] alb3rtobr opened a new pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

alb3rtobr opened a new pull request #662:
URL: https://github.com/apache/geode-native/pull/662


   This ticket is an improvement over GEODE-8231:
   
   > If a C++ client connected to a cluster is sending operations to a partitioned region and one of the server goes down, the client keeps trying to send operations to the down server. This can be observed in the logs by a continuous flow of lines containing: "IO error in handshake with endpoint..."
   
   After that improvement, the c++ client removes the metadata info of the failing server once the "IO error in handshake" is received.
   
   But it has been observed that before that error is received, "timeout error" can be returned. So the client will try to reconnect until the "IO error in handshake" is received.
   
   This ticket aims to extend the GEODE-8231 solution so the client removes the server metadata information when a timeout is received.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705764533


   @alb3rtobr The build fix has a clangformat issue, sorry.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705540765






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705540765


   There is still one issue on windows build, Im on it
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705764533


   @alb3rtobr The build fix has a clangformat issue, sorry.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] mreddington commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
mreddington commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r500546322



##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+#include <stdio.h>

Review comment:
       Why is this header necessary?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r500551118



##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -15,6 +15,8 @@
  * limitations under the License.
  */
 
+#include <stdio.h>

Review comment:
       Good catch, it is not needed. I forgot to remove it when preparing the PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r500556185



##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -1427,17 +1427,18 @@ GfErrType ThinClientPoolDM::sendSyncRequest(
             GF_SAFE_DELETE_CON(conn);
           }
           excludeServers.insert(ServerLocation(ep->name()));
-          if (error == GF_IOERR) {
+          if (error == GF_IOERR || error == GF_TIMEOUT) {

Review comment:
       +1! And the same in line 2355




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] mreddington commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
mreddington commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r500552393



##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -46,11 +48,21 @@ using apache::geode::client::RegionShortcut;
 
 using std::chrono::minutes;
 
+std::string getClientLogName() {

Review comment:
       Oof... Man, I looked into why you're doing this, and I get you, and I'm just as sorry.
   
   Can I convince you to add a refactor that will eliminate all this dubious file handling? If you look at cppcache/src/Log.cpp, there are 2 places, 2 lines each, where we fprintf(stdout... and a flush. What if you replaced both those with a write to ::std::cerr? No need to flush, cerr has unitbuf enabled by default.
   
   What this should allow you to do, but I'm not exactly familiar with how this behaves over a shared object boundary, is you can replace the stream buffer of cerr with your own.
   
   ::std::istringstream log_stream;
   auto old_rdbuf = ::std::cerr.rdbuf(log_stream.rdbuf());
   // Test code...
   ::std::getline(log_stream, log_line);
   // etc...
   ::std::cerr.rdbuf(old_rdbuf);




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-703769126


   I have added extra logic in the test cases added in GEODE-8231 to verify that the client metadata was verified at the first error that appeared:
   In case there was a timeout received by the client, the log has to contain a message saying the `bucketServerLocation` was removed due to a timeout.
   And if there was an IO error, the log has to contain a message saying the `bucketServerLocation` was removed due to an IO error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] mreddington commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
mreddington commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r501187346



##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -46,11 +48,21 @@ using apache::geode::client::RegionShortcut;
 
 using std::chrono::minutes;
 
+std::string getClientLogName() {

Review comment:
       @alb3rtobr I'm probably missing something. Streams are mostly brilliant until you start mucking with their details. I'm glad you tried it. I think I'll figure this one out and then make a separate ticket for it. We have a lot of testing that would benefit from internal log redirection. Thanks, mate.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705105447


   This has build issues on Windows:
   ```
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(106): error C2079: 'previousTestLog' uses undefined class 'std::basic_ifstream<char,std::char_traits<char>>' [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(106): error C2440: 'initializing': cannot convert from 'std::string' to 'int' [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
     C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(106): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(115): error C2079: 'testLog' uses undefined class 'std::basic_ifstream<char,std::char_traits<char>>' [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(115): error C2440: 'initializing': cannot convert from 'std::string' to 'int' [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
     C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(115): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133): error C2672: 'getline': no matching overloaded function found [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133): error C2784: 'std::basic_istream<_Elem,_Traits> &std::getline(std::basic_istream<_Elem,_Traits> &,std::basic_string<_Elem,_Traits,_Alloc> &)': could not deduce template argument for 'std::basic_istream<_Elem,_Traits> &' from 'int' [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
     C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.15.26726\include\string(160): note: see declaration of 'std::getline'
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133): error C2780: 'std::basic_istream<_Elem,_Traits> &std::getline(std::basic_istream<_Elem,_Traits> &,std::basic_string<_Elem,_Traits,_Alloc> &,const _Elem)': expects 3 arguments - 2 provided [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
     C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.15.26726\include\string(149): note: see declaration of 'std::getline'
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133): error C2784: 'std::basic_istream<_Elem,_Traits> &std::getline(std::basic_istream<_Elem,_Traits> &&,std::basic_string<_Elem,_Traits,_Alloc> &)': could not deduce template argument for 'std::basic_istream<_Elem,_Traits> &&' from 'int' [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
     C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.15.26726\include\string(129): note: see declaration of 'std::getline'
   C:\nativeclient\cppcache\integration\test\PartitionRegionOpsTest.cpp(133): error C2780: 'std::basic_istream<_Elem,_Traits> &std::getline(std::basic_istream<_Elem,_Traits> &&,std::basic_string<_Elem,_Traits,_Alloc> &,const _Elem)': expects 3 arguments - 2 provided [C:\build\cppcache\integration\test\cpp-integration-test.vcxproj]
     C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.15.26726\include\string(76): note: see declaration of 'std::getline'
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r500601281



##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -46,11 +48,21 @@ using apache::geode::client::RegionShortcut;
 
 using std::chrono::minutes;
 
+std::string getClientLogName() {

Review comment:
       @mreddington I have tried your approach (check last commit) but it does not work fine. There are no lines when reading from the `istringstream`, it seems empty. Am I missing something?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] codecov-io commented on pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705167622


   # [Codecov](https://codecov.io/gh/apache/geode-native/pull/662?src=pr&el=h1) Report
   > Merging [#662](https://codecov.io/gh/apache/geode-native/pull/662?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/2e64e74e3b29c9813776c80b34b84606ec7b8274?el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `56.25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/662/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/662?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #662      +/-   ##
   ===========================================
   - Coverage    74.16%   73.87%   -0.29%     
   ===========================================
     Files          644      644              
     Lines        51131    51133       +2     
   ===========================================
   - Hits         37920    37774     -146     
   - Misses       13211    13359     +148     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/662?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw) | `75.01% <56.25%> (+0.39%)` | :arrow_up: |
   | [cppcache/src/PutAllPartialResult.cpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1B1dEFsbFBhcnRpYWxSZXN1bHQuY3Bw) | `0.00% <0.00%> (-47.62%)` | :arrow_down: |
   | [cppcache/src/VersionedCacheableObjectPartList.hpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1ZlcnNpb25lZENhY2hlYWJsZU9iamVjdFBhcnRMaXN0LmhwcA==) | `52.70% <0.00%> (-27.03%)` | :arrow_down: |
   | [cppcache/src/CacheableObjectPartList.hpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlYWJsZU9iamVjdFBhcnRMaXN0LmhwcA==) | `62.50% <0.00%> (-25.00%)` | :arrow_down: |
   | [cppcache/src/ReadWriteLock.cpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlYWRXcml0ZUxvY2suY3Bw) | `81.25% <0.00%> (-18.75%)` | :arrow_down: |
   | [cppcache/src/ThinClientStickyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRTdGlja3lNYW5hZ2VyLmNwcA==) | `77.88% <0.00%> (-10.58%)` | :arrow_down: |
   | [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `55.99% <0.00%> (-5.12%)` | :arrow_down: |
   | [cppcache/src/PutAllPartialResult.hpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1B1dEFsbFBhcnRpYWxSZXN1bHQuaHBw) | `0.00% <0.00%> (-4.55%)` | :arrow_down: |
   | [cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=) | `62.24% <0.00%> (-3.90%)` | :arrow_down: |
   | [cppcache/src/ClientMetadata.cpp](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhLmNwcA==) | `65.16% <0.00%> (-0.57%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/geode-native/pull/662/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/662?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/662?src=pr&el=footer). Last update [2e64e74...bee8e54](https://codecov.io/gh/apache/geode-native/pull/662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] mreddington commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
mreddington commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r500554917



##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -2351,11 +2352,12 @@ TcrConnection* ThinClientPoolDM::getConnectionFromQueueW(
                   version);
         }
         return nullptr;
-      } else if (*error == GF_IOERR) {
+      } else if (*error == GF_IOERR || *error == GF_TIMEOUT) {

Review comment:
       Combine, reduce nesting, etc...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] pdxcodemonkey merged pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey merged pull request #662:
URL: https://github.com/apache/geode-native/pull/662


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] mreddington commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
mreddington commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r500554011



##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -1427,17 +1427,18 @@ GfErrType ThinClientPoolDM::sendSyncRequest(
             GF_SAFE_DELETE_CON(conn);
           }
           excludeServers.insert(ServerLocation(ep->name()));
-          if (error == GF_IOERR) {
+          if (error == GF_IOERR || error == GF_TIMEOUT) {

Review comment:
       Can you combine these nested conditions into one and remove a whole level of indentation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r501190200



##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -46,11 +48,21 @@ using apache::geode::client::RegionShortcut;
 
 using std::chrono::minutes;
 
+std::string getClientLogName() {

Review comment:
       @mreddington No problem, thanks for the suggestion anyway. Im going to revert the last commit then. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on a change in pull request #662:
URL: https://github.com/apache/geode-native/pull/662#discussion_r501194315



##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -46,11 +48,21 @@ using apache::geode::client::RegionShortcut;
 
 using std::chrono::minutes;
 
+std::string getClientLogName() {

Review comment:
       @mreddington Please remember to approve the PR if its fine for you :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode-native] alb3rtobr commented on pull request #662: GEODE-8565: Remove bucketServerLocation if timeout error

Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705768480


   > @alb3rtobr The build fix has a clangformat issue, sorry.
   
   I hate when this happens.. sorry! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org