You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/21 03:08:02 UTC

[commons-codec] branch master updated: Use final.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 9d0d991  Use final.
9d0d991 is described below

commit 9d0d9919a8813df04e2cc126086e3f824872420f
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 22:07:57 2020 -0500

    Use final.
---
 src/main/java/org/apache/commons/codec/binary/Base32.java               | 2 +-
 .../org/apache/commons/codec/language/MatchRatingApproachEncoder.java   | 2 +-
 .../java/org/apache/commons/codec/binary/CharSequenceUtilsTest.java     | 2 +-
 .../org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/binary/Base32.java b/src/main/java/org/apache/commons/codec/binary/Base32.java
index 483d82d..0b165c1 100644
--- a/src/main/java/org/apache/commons/codec/binary/Base32.java
+++ b/src/main/java/org/apache/commons/codec/binary/Base32.java
@@ -314,7 +314,7 @@ public class Base32 extends BaseNCodec {
      * @since 1.15
      */
     public Base32(final int lineLength, final byte[] lineSeparator, final boolean useHex,
-                  final byte padding, CodecPolicy decodingPolicy) {
+                  final byte padding, final CodecPolicy decodingPolicy) {
         super(BYTES_PER_UNENCODED_BLOCK, BYTES_PER_ENCODED_BLOCK, lineLength,
                 lineSeparator == null ? 0 : lineSeparator.length, padding, decodingPolicy);
         if (useHex) {
diff --git a/src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java b/src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
index 9cba4a6..acb1af7 100644
--- a/src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
+++ b/src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
@@ -247,7 +247,7 @@ public class MatchRatingApproachEncoder implements StringEncoder {
         // 5. Obtain the minimum rating value by calculating the length sum of the
         // encoded Strings and sending it down.
         final int sumLength = Math.abs(name1.length() + name2.length());
-        int minRating = getMinRating(sumLength);
+        final int minRating = getMinRating(sumLength);
 
         // 6. Process the encoded Strings from left to right and remove any
         // identical characters found from both Strings respectively.
diff --git a/src/test/java/org/apache/commons/codec/binary/CharSequenceUtilsTest.java b/src/test/java/org/apache/commons/codec/binary/CharSequenceUtilsTest.java
index e903184..0b7518a 100644
--- a/src/test/java/org/apache/commons/codec/binary/CharSequenceUtilsTest.java
+++ b/src/test/java/org/apache/commons/codec/binary/CharSequenceUtilsTest.java
@@ -110,7 +110,7 @@ public class CharSequenceUtilsTest {
                 try {
                     invoke();
                     Assert.fail(msg + " but nothing was thrown.");
-                } catch (Exception ex) {
+                } catch (final Exception ex) {
                     assertTrue(msg + " but was " + ex.getClass().getSimpleName(),
                             data.throwable.isAssignableFrom(ex.getClass()));
                 }
diff --git a/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java b/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java
index 03db8c5..4d1f576 100644
--- a/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java
+++ b/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java
@@ -172,7 +172,7 @@ public class MessageDigestAlgorithmsTest {
         Assert.assertArrayEquals(digestTestData(), DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm),new ByteArrayInputStream(getTestData())));
     }
 
-    private void testDigestPath(OpenOption... options) throws IOException {
+    private void testDigestPath(final OpenOption... options) throws IOException {
         Assume.assumeTrue(DigestUtils.isAvailable(messageDigestAlgorithm));
         Assert.assertArrayEquals(digestTestData(),
             DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm), getTestPath(), options));