You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/04/24 17:32:53 UTC
[GitHub] [tomcat] KangZhiDong opened a new pull request #285: Avoid waste of resources due to reconstruction of objects
KangZhiDong opened a new pull request #285:
URL: https://github.com/apache/tomcat/pull/285
avoid waste of resources due to reconstruction of objects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #285: Avoid waste of resources due to reconstruction of objects
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #285:
URL: https://github.com/apache/tomcat/pull/285#issuecomment-623504537
The only one I'm concerned about is `JspFactoryImpl` as this would open up the possibility of one web application being able to impact another. I'll merge this manually so I can skip that class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #285: Avoid waste of resources due to reconstruction of objects
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #285:
URL: https://github.com/apache/tomcat/pull/285#issuecomment-623492707
Re-opening, as I have done most of the analysis required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #285: Avoid waste of resources due to reconstruction of objects
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #285:
URL: https://github.com/apache/tomcat/pull/285#issuecomment-622515717
What is the performance benefit here? I'm concerned that some error paths, particularly around unhandled exceptions might lead to memory leaks. The PR needs very careful analysis before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #285: Avoid waste of resources due to reconstruction of objects
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #285:
URL: https://github.com/apache/tomcat/pull/285#issuecomment-623510920
Merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org