You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/12/06 11:40:00 UTC
[kudu-CR] Silence gcc warning on TimeManager::GetSafeTimeUnlocked()
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5381
Change subject: Silence gcc warning on TimeManager::GetSafeTimeUnlocked()
......................................................................
Silence gcc warning on TimeManager::GetSafeTimeUnlocked()
gcc is issuing this warning:
../../src/kudu/consensus/time_manager.cc: In member function \u2018kudu::Timestamp kudu::consensus::TimeManager::GetSafeTimeUnlocked()\u2019:
../../src/kudu/consensus/time_manager.cc:232:1: warning: control reaches end of non-void function [-Wreturn-type]
This patch silences it by using '__builtin_unreachable()'.
Change-Id: I7a87b483453115ae34615698017482a0364b5dca
---
M src/kudu/consensus/time_manager.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/5381/1
--
To view, visit http://gerrit.cloudera.org:8080/5381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a87b483453115ae34615698017482a0364b5dca
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Silence gcc warning on TimeManager::GetSafeTimeUnlocked()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Silence gcc warning on TimeManager::GetSafeTimeUnlocked()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a87b483453115ae34615698017482a0364b5dca
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Silence gcc warning on TimeManager::GetSafeTimeUnlocked()
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Silence gcc warning on TimeManager::GetSafeTimeUnlocked()
......................................................................
Silence gcc warning on TimeManager::GetSafeTimeUnlocked()
gcc is issuing this warning:
../../src/kudu/consensus/time_manager.cc: In member function \u2018kudu::Timestamp kudu::consensus::TimeManager::GetSafeTimeUnlocked()\u2019:
../../src/kudu/consensus/time_manager.cc:232:1: warning: control reaches end of non-void function [-Wreturn-type]
This patch silences it by using '__builtin_unreachable()'.
Change-Id: I7a87b483453115ae34615698017482a0364b5dca
Reviewed-on: http://gerrit.cloudera.org:8080/5381
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/time_manager.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a87b483453115ae34615698017482a0364b5dca
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>