You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Guozhang Wang <wa...@gmail.com> on 2015/02/12 20:36:23 UTC

Review Request 30946: Fix KAFKA-1948

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30946/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1948
    https://issues.apache.org/jira/browse/KAFKA-1948


Repository: kafka


Description
-------

KAFKA-1948.v1


Diffs
-----

  core/src/main/scala/kafka/controller/KafkaController.scala 66df6d2fbdbdd556da6bea0df84f93e0472c8fbf 
  core/src/test/scala/integration/kafka/api/ConsumerTest.scala 798f035df52e405176f558806584ce25e8c392ac 

Diff: https://reviews.apache.org/r/30946/diff/


Testing
-------


Thanks,

Guozhang Wang

Re: Review Request 30946: Fix KAFKA-1948

Posted by Neha Narkhede <ne...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30946/#review73435
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Feb. 12, 2015, 7:36 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30946/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 7:36 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1948
>     https://issues.apache.org/jira/browse/KAFKA-1948
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1948.v1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/KafkaController.scala 66df6d2fbdbdd556da6bea0df84f93e0472c8fbf 
>   core/src/test/scala/integration/kafka/api/ConsumerTest.scala 798f035df52e405176f558806584ce25e8c392ac 
> 
> Diff: https://reviews.apache.org/r/30946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Re: Review Request 30946: Fix KAFKA-1948

Posted by Jay Kreps <bo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30946/#review72278
-----------------------------------------------------------

Ship it!


Ship It!

- Jay Kreps


On Feb. 12, 2015, 7:36 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30946/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 7:36 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1948
>     https://issues.apache.org/jira/browse/KAFKA-1948
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1948.v1
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/KafkaController.scala 66df6d2fbdbdd556da6bea0df84f93e0472c8fbf 
>   core/src/test/scala/integration/kafka/api/ConsumerTest.scala 798f035df52e405176f558806584ce25e8c392ac 
> 
> Diff: https://reviews.apache.org/r/30946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>