You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dabla (via GitHub)" <gi...@apache.org> on 2024/06/18 12:05:51 UTC
[PR] refactor: Make sure xcoms work correctly with MSGraphAsyncOperator with concurrent workers [airflow]
dabla opened a new pull request, #40297:
URL: https://github.com/apache/airflow/pull/40297
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This pull request makes sure xcoms work correctly in a multi-threaded environment (e.g. when applying dynamic task mapping with concurrent workers) by taking the map_index into account when pushing and pulling xcoms.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Make sure xcoms work correctly in MSGraphAsyncOperator with concurrent workers [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #40297:
URL: https://github.com/apache/airflow/pull/40297#issuecomment-2176012376
> Is it possible to add unit test for that to avoid regressions ?
That would mean a unit test using multiple threads as I need concurrency to reproduce it. Are there any examples of unit tests using multiple threads?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Make sure xcoms work correctly in MSGraphAsyncOperator with concurrent workers [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #40297:
URL: https://github.com/apache/airflow/pull/40297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Make sure xcoms work correctly in MSGraphAsyncOperator with concurrent workers [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #40297:
URL: https://github.com/apache/airflow/pull/40297#issuecomment-2176003482
Is it possible to add unit test for that to avoid regressions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Make sure xcoms work correctly in MSGraphAsyncOperator with concurrent workers [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #40297:
URL: https://github.com/apache/airflow/pull/40297#issuecomment-2176020553
> That would mean a unit test using multiple threads as I need concurrency to reproduce it. Are there any examples of unit tests using multiple threads?
When I search in `tests` there are at least few `Thread(` usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Make sure xcoms work correctly in MSGraphAsyncOperator with concurrent workers [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #40297:
URL: https://github.com/apache/airflow/pull/40297#issuecomment-2176072150
The problem with Python is that the basic threading doesn't do real multithreading, so I don't know if I will be able to reproduce it as we did encounter the issues with multiple workers being deployed across multiple pods. So in order to test this correctly, I would be force to use the multiprocessing pyhton module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Make sure xcoms work correctly in MSGraphAsyncOperator with concurrent workers [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla commented on PR #40297:
URL: https://github.com/apache/airflow/pull/40297#issuecomment-2176062512
> > That would mean a unit test using multiple threads as I need concurrency to reproduce it. Are there any examples of unit tests using multiple threads?
>
> When I search in `tests` there are at least few `Thread(` usages 😄
Ok will also search then, I just asked because I know from experience that test with threads can something mess up the whole test pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: Make sure xcoms work correctly in MSGraphAsyncOperator with concurrent workers [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #40297:
URL: https://github.com/apache/airflow/pull/40297#issuecomment-2176188833
> The problem with Python is that the basic threading doesn't do real multithreading, so I don't know if I will be able to reproduce it as we did encounter the issues with multiple workers being deployed across multiple pods. So in order to test this correctly, I would be force to use the multiprocessing pyhton module.
Yeah. If it's too much of a hassle and reproducibility is difficult, then yeah we can definitely skip tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org