You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Isuru Perera <is...@wso2.com> on 2013/08/21 20:14:15 UTC
Topology sync code changes
Hi all,
Just a heads up!
I will be doing some changes to Topology sync logic.
Related JIRAs
https://issues.apache.org/jira/browse/STRATOS-48
https://issues.apache.org/jira/browse/STRATOS-52
Objectives:
1. Common Message Broker configuration in all Stratos Products (Cloud
Controller, Stratos Controller and ELB)
2. Support for other message brokers. Planning to test with Apache
ActiveMQ and WSO2 Message Broker first.
I will let you all know more details later.
Thanks!
--
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware
about.me/chrishantha
Re: Topology sync code changes
Posted by Isuru Perera <is...@wso2.com>.
Hi,
While working on this, I found there are almost duplicate lines of code in
following classes.
*TopicHealthChecker.java*
./org.apache.stratos.lb.endpoint/src/main/java/org/apache/stratos/lb/endpoint/subscriber/TopicHealthChecker.java
./org.apache.stratos.adc.topology.mgt/src/main/java/org/apache/stratos/adc/topology/mgt/subscriber/TopicHealthChecker.java
*TopologySubscriber.java*
./org.apache.stratos.lb.endpoint/src/main/java/org/apache/stratos/lb/endpoint/subscriber/TopologySubscriber.java
./org.apache.stratos.adc.topology.mgt/src/main/java/org/apache/stratos/adc/topology/mgt/subscriber/TopologySubscriber.java
*TopologyListener.java*
./org.apache.stratos.lb.endpoint/src/main/java/org/apache/stratos/lb/endpoint/subscriber/TopologyListener.java
./org.apache.stratos.adc.topology.mgt/src/main/java/org/apache/stratos/adc/topology/mgt/subscriber/TopologyListener.java
Following also has some common code.
*TopologySyncher.java*
./org.apache.stratos.lb.endpoint/src/main/java/org/apache/stratos/lb/endpoint/builder/TopologySyncher.java
./org.apache.stratos.adc.topology.mgt/src/main/java/org/apache/stratos/adc/topology/mgt/builder/TopologySyncher.java
As I said, we need to get these common code to a single component.
I need to think carefully, review existing components and design the
components properly.
I'm just holding off this work for few days as we are preparing for a
release and I don't want to bring any considerable code changes.
I will start working on this as soon as we could do a proper Apache Stratos
(incubating) release first. This means that the first release will support
only WSO2 Message Broker as it was designed originally.
Thank you.
Best Regards,
On Thu, Aug 22, 2013 at 9:50 AM, Isuru Perera <is...@wso2.com> wrote:
> On Thu, Aug 22, 2013 at 9:11 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>
>> Make sure, you don't push these changes, until you are confident that
>> this not break any other flow. I would like to have feature freeze, since
>> we plan to do a release next week.
>>
> Yes. I will be pushing only after testing.
>
> Thanks!
>
>> sent from phone
>> On Aug 21, 2013 11:45 PM, "Isuru Perera" <is...@wso2.com> wrote:
>>
>>> Hi all,
>>>
>>> Just a heads up!
>>>
>>> I will be doing some changes to Topology sync logic.
>>>
>>> Related JIRAs
>>> https://issues.apache.org/jira/browse/STRATOS-48
>>> https://issues.apache.org/jira/browse/STRATOS-52
>>>
>>> Objectives:
>>>
>>> 1. Common Message Broker configuration in all Stratos Products
>>> (Cloud Controller, Stratos Controller and ELB)
>>> 2. Support for other message brokers. Planning to test with Apache
>>> ActiveMQ and WSO2 Message Broker first.
>>>
>>>
>>> I will let you all know more details later.
>>>
>>> Thanks!
>>>
>>> --
>>> Isuru Perera
>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>>> Lean . Enterprise . Middleware
>>>
>>> about.me/chrishantha
>>>
>>
>
>
> --
> Isuru Perera
> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
> Lean . Enterprise . Middleware
>
> about.me/chrishantha
>
--
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware
about.me/chrishantha
Re: Topology sync code changes
Posted by Isuru Perera <is...@wso2.com>.
On Thu, Aug 22, 2013 at 9:11 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
> Make sure, you don't push these changes, until you are confident that this
> not break any other flow. I would like to have feature freeze, since we
> plan to do a release next week.
>
Yes. I will be pushing only after testing.
Thanks!
> sent from phone
> On Aug 21, 2013 11:45 PM, "Isuru Perera" <is...@wso2.com> wrote:
>
>> Hi all,
>>
>> Just a heads up!
>>
>> I will be doing some changes to Topology sync logic.
>>
>> Related JIRAs
>> https://issues.apache.org/jira/browse/STRATOS-48
>> https://issues.apache.org/jira/browse/STRATOS-52
>>
>> Objectives:
>>
>> 1. Common Message Broker configuration in all Stratos Products (Cloud
>> Controller, Stratos Controller and ELB)
>> 2. Support for other message brokers. Planning to test with Apache
>> ActiveMQ and WSO2 Message Broker first.
>>
>>
>> I will let you all know more details later.
>>
>> Thanks!
>>
>> --
>> Isuru Perera
>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>> Lean . Enterprise . Middleware
>>
>> about.me/chrishantha
>>
>
--
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware
about.me/chrishantha
Re: Topology sync code changes
Posted by Isuru Haththotuwa <is...@wso2.com>.
Yes, we should not be doing any drastic changes now. We can push them in
after the initial release. IMHO it is better if we can still provide a
Message Broker (maybe a separate JVM as you have mentioned) for the demo
scenarios, or else a user who is simply trying to run the demo will have to
configure the MB.
On Thu, Aug 22, 2013 at 9:11 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
> Make sure, you don't push these changes, until you are confident that this
> not break any other flow. I would like to have feature freeze, since we
> plan to do a release next week.
>
> sent from phone
> On Aug 21, 2013 11:45 PM, "Isuru Perera" <is...@wso2.com> wrote:
>
>> Hi all,
>>
>> Just a heads up!
>>
>> I will be doing some changes to Topology sync logic.
>>
>> Related JIRAs
>> https://issues.apache.org/jira/browse/STRATOS-48
>> https://issues.apache.org/jira/browse/STRATOS-52
>>
>> Objectives:
>>
>> 1. Common Message Broker configuration in all Stratos Products (Cloud
>> Controller, Stratos Controller and ELB)
>> 2. Support for other message brokers. Planning to test with Apache
>> ActiveMQ and WSO2 Message Broker first.
>>
>>
>> I will let you all know more details later.
>>
>> Thanks!
>>
>> --
>> Isuru Perera
>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>> Lean . Enterprise . Middleware
>>
>> about.me/chrishantha
>>
>
--
Thanks and Regards,
Isuru H.
Re: Topology sync code changes
Posted by Lakmal Warusawithana <la...@wso2.com>.
Make sure, you don't push these changes, until you are confident that this
not break any other flow. I would like to have feature freeze, since we
plan to do a release next week.
sent from phone
On Aug 21, 2013 11:45 PM, "Isuru Perera" <is...@wso2.com> wrote:
> Hi all,
>
> Just a heads up!
>
> I will be doing some changes to Topology sync logic.
>
> Related JIRAs
> https://issues.apache.org/jira/browse/STRATOS-48
> https://issues.apache.org/jira/browse/STRATOS-52
>
> Objectives:
>
> 1. Common Message Broker configuration in all Stratos Products (Cloud
> Controller, Stratos Controller and ELB)
> 2. Support for other message brokers. Planning to test with Apache
> ActiveMQ and WSO2 Message Broker first.
>
>
> I will let you all know more details later.
>
> Thanks!
>
> --
> Isuru Perera
> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
> Lean . Enterprise . Middleware
>
> about.me/chrishantha
>