You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by foogaro <gi...@git.apache.org> on 2014/07/30 11:24:04 UTC
[GitHub] struts pull request: Localized by classloader
GitHub user foogaro opened a pull request:
https://github.com/apache/struts/pull/19
Localized by classloader
**This update enables struts to be used as JBoss AS 7/WildFly 8/JBoss EAP 6 module.**
_**Issue:**_
having two or more applications using the same "struts-module" (meant as JBoss AS 7 module),
each application with its own resource bundle, the first one which initialized the LocalizedTextUtil "wins" over the second and next application's resource bundles. Furthermore, to avoid overwriting bundles, now each bundle is indexed into the **bundlesMap** by its key (resourceBundleName) and prefixed by ClassLoader hash code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/redhat-italy/struts localized-by-classloader
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 2de0f4b5b10627c53f85a895d310fdaa53c0d2b0
Author: Luigi Fugaro <l....@gmail.com>
Date: 2014-07-29T15:44:28Z
This update enables struts to be used as JBoss AS 7/WildFly 8/JBoss EAP 6 module.
commit 4586d1f148ef43c7582038306a626144c75d0e49
Author: Luigi Fugaro <l....@gmail.com>
Date: 2014-07-29T15:46:04Z
Added pom's version as 2.3.16.4-SNAPSHOT
commit c826d97cafafc9ce54e15745b23cd211e233c2fa
Author: Luigi Fugaro <l....@gmail.com>
Date: 2014-07-29T16:44:50Z
Removed unused code, comments and variables. Also, added delegatedClassLoaderMap to handle delegatedClassLoader as per Tomcat.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Localized by classloader
Posted by foogaro <gi...@git.apache.org>.
Github user foogaro commented on the pull request:
https://github.com/apache/struts/pull/19#issuecomment-50594012
Redoing it, targeting develop branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Localized by classloader
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/19#issuecomment-50593699
Two issues:
- please open this PR against `develop` branch, not `master`
- please register an issue in JIRA and reference this branch from it
https://issues.apache.org/jira/browse/WW
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Localized by classloader
Posted by foogaro <gi...@git.apache.org>.
Github user foogaro closed the pull request at:
https://github.com/apache/struts/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org