You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/15 02:38:31 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #25155: [SPARK-28392][SQL][TESTS] Add traits for UDF and PostgreSQL tests to share initialization

HyukjinKwon opened a new pull request #25155: [SPARK-28392][SQL][TESTS] Add traits for UDF and PostgreSQL tests to share initialization
URL: https://github.com/apache/spark/pull/25155
 
 
   ## What changes were proposed in this pull request?
   
   This PR adds some traits so that we can deduplicate initialization stuff for each type of test case. For instance, see [SPARK-28343](https://issues.apache.org/jira/browse/SPARK-28343).
   
   It's a little bit overkill but I think it will make adding test cases easier and cause less confusions.
   
   This PR adds both:
   
   ```
     private trait PgSQLTest
     private trait UDFTest
   ```
   
   To indicate and share the logics related to each combination of test types.
   
   ## How was this patch tested?
   
   Manually tested.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org